MegaMek / mekhq

MekHQ is a java helper program for the MegaMek game that allows users to load a list of entities from an XML file, perform repairs and customizations, and then save the new entities to another XML file that can be loaded into MegaMek.
http://megamek.org
131 stars 169 forks source link

[0.50.01 #CI1618]: Importing campaign from 0.50 removes all awards from personnel #4852

Closed UlyssesSockdrawer closed 2 weeks ago

UlyssesSockdrawer commented 3 weeks ago

Prerequisites and Pre-Issue Checklist

Severity *

Medium (Gameplay Limitation): Non-core functionality is impaired, providing a suboptimal but playable experience.

Brief Description *

Importing a campaign from 0.50 into the 0.50.01 nightly removes all awards from personnel. The awards are still shown in the pilot's personal log. I suspect this may somehow be linked to the mekkening of names. May be one for @IllianiCBT

Auto-awards continues to assign correctly after scenarios to mekwarriors.

0.50.01 screenshot:

image

0.50 screenshot of same pilot:

image

Steps to Reproduce

  1. Load provided save-game in 0.50 - check that awards are present.
  2. Load provided save-game in 0.50.01 #CI1618 nightly
  3. View personnel records - awards show in personal log but are missing from personnel

Operating System *

Windows 11

Java Version *

17.0.12

MekHQ Suite Version *

Free Text (type manually)

Custom MekHQ Version

50.01 CI1618 Nightly

Attach Files

0.50 save with medals: The Nova Dragoons30050716.cpnx.gz

customs.zip

Final Checklist

Tzahr commented 3 weeks ago

This issue is not isolated to imported campaign saves. Rewards do not load at all from any savegame made in this build.

This can very easily be tested by creating a new campaign, and using the default company generator, which will normally generate you with personnel that qualify for the Marksman award, and automatically promt you to do so. Confirm this, and make note of which personnel received the reward. Save the game, and reload it: the reward is no longer there, and running the eglibility dialogue re-awards it.

So: rewards are failing to load correctly in general.

EDIT: appending a log file that contains some AutoAward errors. This was for following the above steps. mekhq.log

IllianiCBT commented 2 weeks ago

Closing as resolved