MegaMek / mekhq

MekHQ is a java helper program for the MegaMek game that allows users to load a list of entities from an XML file, perform repairs and customizations, and then save the new entities to another XML file that can be loaded into MegaMek.
http://megamek.org
134 stars 171 forks source link

Removed TN Modifier for IS Techs working on Clan Tech, Removed Clan Tech Knowledge SPA and Effects #4863

Closed IllianiCBT closed 1 month ago

IllianiCBT commented 2 months ago

Removed all instances of the 'Clan Tech Knowledge' SPA from PersonnelOptions, Part, and defaultspa.xml.

Recently, errata removed the +2 modifier to TNs when IS teams work on Clan-based equipment. This rendered the above SPA no longer relevant.

Closes #4782

codecov-commenter commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 10.30%. Comparing base (752cc96) to head (fd201e6). Report is 125 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #4863 +/- ## ============================================ - Coverage 10.30% 10.30% -0.01% + Complexity 5871 5870 -1 ============================================ Files 944 944 Lines 131394 131392 -2 Branches 19063 19057 -6 ============================================ - Hits 13545 13534 -11 - Misses 116532 116540 +8 - Partials 1317 1318 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.