search

MegaMek / mekhq

MekHQ is a java helper program for the MegaMek game that allows users to load a list of entities from an XML file, perform repairs and customizations, and then save the new entities to another XML file that can be loaded into MegaMek.
http://megamek.org
131 stars 168 forks source link

Simplified Tech Personnel Checks #4911

Closed IllianiCBT closed 4 days ago

IllianiCBT commented 4 days ago

Removed experience level checks from tech personnel checks to streamline the determination of technician roles. This removes the really weird situation where ultra-green techs can't be assigned to units (or, in some cases, repair tasks). Whether they should be assigned is something best left to the player. This was particularly odd, as this is the only role that had the 'must be Green or better' restriction.

IllianiCBT commented 4 days ago

For the curious, this was why sometimes you'd end up with techs not assigned to units, when using the company generator.

codecov-commenter commented 4 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 10.45%. Comparing base (2b9ba00) to head (4103d14). Report is 25 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #4911 +/- ## ========================================= Coverage 10.45% 10.45% + Complexity 6006 6005 -1 ========================================= Files 952 952 Lines 132755 132753 -2 Branches 19308 19304 -4 ========================================= Hits 13882 13882 + Misses 117527 117523 -4 - Partials 1346 1348 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.