search

MegaMek / mekhq

MekHQ is a java helper program for the MegaMek game that allows users to load a list of entities from an XML file, perform repairs and customizations, and then save the new entities to another XML file that can be loaded into MegaMek.
http://megamek.org
131 stars 168 forks source link

Refactored DropShip Salvage Handling #4922

Closed IllianiCBT closed 3 days ago

IllianiCBT commented 4 days ago

Moved DropShip Bonus calculation outside of the conditional block for ejected units. This change ensures that the DropShip bonus is consistently applied. Adjusted the existing logic to avoid redundant checks and improve code readability.

Refactored processGame to remove single or abbreviated variable names.

Closes #4845

codecov-commenter commented 4 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 10.46%. Comparing base (b8b9400) to head (e1d1251). Report is 44 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #4922 +/- ## ========================================= Coverage 10.45% 10.46% - Complexity 6008 6015 +7 ========================================= Files 952 951 -1 Lines 132759 132835 +76 Branches 19309 19309 ========================================= + Hits 13885 13895 +10 - Misses 117518 117589 +71 + Partials 1356 1351 -5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.