[0.50.01-SNAPSHOT] AtB contract market generates contracts with very high base pay values.

Tzahr commented 1 month ago

Prerequisites and Pre-Issue Checklist

[X] I'm reporting the issue to the correct repository:
MegaMek
MegaMekLab
MekHQ
[X] I've tested the issue against at least the latest MILESTONE version
[X] I've asked on the MegaMek Discord about the error
[X] I've reviewed the BattleTech rules and MekHQ documentation, and I've confirmed that something isn't working as intended.
[X] I've searched the Github tracker and haven't found the issue listed

Severity *

Medium (Gameplay Limitation): Non-core functionality is impaired, providing a suboptimal but playable experience.

Brief Description *

When generating contracts through the AtB Contract Marker, contracts generate with very high base pay values. This is more visible on more mature mercenary companies where the expected values are clearly inflated on the higher end. When comparing payouts of contracts generated in previous versions compared to contracts generated on current, we notice up to ten times increase in payout value.

The base pay range seems quite broad, suggesting a faulty multiplier somewhere. It is hard to reliably detect in new companies, though batch creating contracts will result in some contracts generating with a much higher base pay that is expected (up to 20 - 40 million range).

The workaround is to manually lower the base pay values (suggested divide by 10).

Steps to Reproduce

Generate new contracts with GM mode using the AtB contract markets, and monitor the expected profits and base pay values. If possible, compare newly generated contracts from a previous version with one from a current version.