MegaMek / mekhq

MekHQ is a java helper program for the MegaMek game that allows users to load a list of entities from an XML file, perform repairs and customizations, and then save the new entities to another XML file that can be loaded into MegaMek.
http://megamek.org
134 stars 171 forks source link

50.01 Aerospace Heat displaying incorrectly in ingame MekHQ Meklab #5164

Open poiu18894012 opened 2 weeks ago

poiu18894012 commented 2 weeks ago

Prerequisites and Pre-Issue Checklist

Severity *

Medium (Gameplay Limitation): Non-core functionality is impaired, providing a suboptimal but playable experience.

Brief Description *

Hello The Aerospace heat is displayed incorrectly when refitting an Aerospace vehicle in MekHQ. This is affecting the artifact version 50.01

Instead of displaying (Total heat generated)/(Total heat sinking)

it displays 2.0/(Total heat sinking)

This affects every aerospace unit (except for LAMs) in 50.01

Screenshot 2024-11-03 162410 Screenshot 2024-11-03 162454 Screenshot 2024-11-03 162548 Screenshot 2024-11-03 162833

Steps to Reproduce

  1. Start customizing an Aerospace Unit
  2. Heat will display wrong regardless of changes.

Operating System *

Windows 11

Java Version *

17.0.12

MekHQ Suite Version *

Free Text (type manually)

Custom MekHQ Version

50.01

Attach Files

logs.zip

Final Checklist

WeaverThree commented 2 weeks ago

I haven't dug into this yet but there's a caulalateTotalHeat() in MekLabTab.java for some reason instead of it just pulling data from the MML functions. https://github.com/WeaverThree/mekhq/blob/b2cc6f71e78cd5702317fd522fa686271f171047/MekHQ/src/mekhq/gui/MekLabTab.java#L399