search

MegaMek / mekhq

MekHQ is a java helper program for the MegaMek game that allows users to load a list of entities from an XML file, perform repairs and customizations, and then save the new entities to another XML file that can be loaded into MegaMek.
http://megamek.org
134 stars 173 forks source link

Corrected Unit Site Comparison Logic #5214

Closed IllianiCBT closed 2 days ago

IllianiCBT commented 1 week ago

Replaced SITE_FACILITY_MAINTENANCE with SITE_FACILITY_BASIC in the comparison logic for unit site determination. This ensures planetary modifiers are only applied in appropriate circumstances.

Closes #5184

codecov-commenter commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 10.50%. Comparing base (bce5f63) to head (aee5977). Report is 20 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #5214 +/- ## ============================================ - Coverage 10.52% 10.50% -0.02% + Complexity 6047 6029 -18 ============================================ Files 957 957 Lines 134523 134523 Branches 19545 19545 ============================================ - Hits 14154 14128 -26 - Misses 119018 119035 +17 - Partials 1351 1360 +9 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features: