MegaMek / mekhq

MekHQ is a java helper program for the MegaMek game that allows users to load a list of entities from an XML file, perform repairs and customizations, and then save the new entities to another XML file that can be loaded into MegaMek.
http://megamek.org
134 stars 173 forks source link

Reputation Error Corrections & Report Reformatting #5216

Closed IllianiCBT closed 2 days ago

IllianiCBT commented 1 week ago

CamOps Reputation now correctly calculates transport rating and command rating.

The CamOps Reputation report dialog has been reformatted to improve usability.

Going from this...

image

To this...

image

Closes #4652, #5194, #5193, #5205

codecov-commenter commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 10.51%. Comparing base (bce5f63) to head (090eec1). Report is 29 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #5216 +/- ## ============================================ - Coverage 10.52% 10.51% -0.01% - Complexity 6047 6048 +1 ============================================ Files 957 957 Lines 134523 134589 +66 Branches 19545 19541 -4 ============================================ - Hits 14154 14152 -2 - Misses 119018 119083 +65 - Partials 1351 1354 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

JonhyBurner commented 1 week ago

Wouldn't the extra transportation rating details fit better in the Transport Report (which could also benefit from a revamp)?

IllianiCBT commented 1 week ago

This report is specifically all the elements that go into CamOps Reputation. Splitting that across multiple reports wouldn’t be a good move imo.

As for revamping the other reports, I only did CamOps Reputation because we absolutely needed it updated under the hood for the move from FM:Mr. I have no interest in touching the other reports give this report alone has took a week+ of dev time.

IllianiCBT commented 3 days ago

Updated to include commander

image image

Closes #5237