search

MegaMek / mekhq

MekHQ is a java helper program for the MegaMek game that allows users to load a list of entities from an XML file, perform repairs and customizations, and then save the new entities to another XML file that can be loaded into MegaMek.
http://megamek.org
131 stars 168 forks source link

Cannot choose "Rasalhague Dominion" as the faction #727

Closed crazys1 closed 6 years ago

crazys1 commented 6 years ago

Environment

What version of MekHQ does your issue apply to?

0.43.10-RC4

What operating system are you using? Windows, Mac, or Linux?

Windows 10

What java version are you using?

Version 8 Update 161, build 1.8.0_161b12

Description

You cannot choose "Rasalhague Dominion" as the faction, even when the campaign year is set to 3103 or later. 3103 is when the Rasalhague Dominion was introducted, according to the factions.xml file.

To reproduce:

  1. Start a new campaign.
  2. Set the year to 3103 or later. You can leave all other settings at the default to save time.
  3. Try to choose "Rasalhague Dominion" as the faction.

This issue is also true for loading an existing campaign and trying to change the faction to "Rasalhague Dominion."

jayof9s commented 6 years ago

As a work around you should be able to pick the Ghost Bears as your faction and they should display as the Rasalhague Dominion once you're settled in for that time period.

crazys1 commented 6 years ago

I can't choose that faction, either. As a test, I just created a new campaign in the year 3110. For Clan factions, I see:

image

jayof9s commented 6 years ago

Interesting. I guess that is tied to the changes to factions that have been made recently. GB probably has an 'end date' in the 3080s (instead of how the name previously just changed to RD) and no one thought to make the RD a playable faction.

Shouldn't be difficult to fix at least, I'll take a look this evening. It should just be a pretty simple change in the factions.xml file if you want to give it a swing just to get it working sooner for your game.

On Thu, May 17, 2018 at 1:40 PM, Crazy S notifications@github.com wrote:

I can't choose that faction, either. As a test, I just created a new campaign in the year 3110. For Clan factions, I see:

[image: image] https://user-images.githubusercontent.com/21768936/40194288-b647a708-59be-11e8-9930-69e6f7e04cc0.png

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/MegaMek/mekhq/issues/727#issuecomment-389949568, or mute the thread https://github.com/notifications/unsubscribe-auth/ANLi4G6Nl0QgJJjg3QUQlFslF06nzXLNks5tzbYSgaJpZM4UDesH .

mkerensky commented 6 years ago

I found some weirdness with the ghost bear factions too - ran into it while working with the Force Generator. Since they change from Clan Ghost Bear to Ghost Bear Dominion to Rasalhague Dominion that's one of the more complicated factions to code...

jayof9s commented 6 years ago

Going to push a fix for this as soon as eclipse gets around to pulling updates from git but it's an easy solution if you don't want to wait for the next release. Go into data/universe/factions.xml and pretty much the first line after all the intro stuff is:

<choosableFactionCodes>MERC,CC,DC,FS,FWL,LA,FC,ROS,CS,WOB,FRR,SIC,MOC,MH,OA,TC,CDS,CGB,CHH,CJF,CNC,CSJ,CSV,CSR,CW,CBS,CCC,CCO,CFM,CGS,CIH,CSA,TH,RWR,CIR,JF,PIR,NIOPS,CDP,HL,NC</choosableFactionCodes>

add ,RD before the closing </choosableFactionChose>

Only issues I saw were that MHQ ignored the starting planet and dropped me on Terra and somehow the Dominion is tagged as IS and not Clan - but with the fluid tech ratings I don't know if that matters as much by 3110.

Edit: fixed so the xml code doesn't disappear (I hope.)

jayof9s commented 6 years ago

RD Should be a a playable option now

crazys1 commented 6 years ago

Excellent; thank you for the prompt action and the interim workaround!