search

MegaPhysics / megaphysics.github.io

A Physics wiki (sort of).
megaphysics.github.io
GNU General Public License v2.0
1 stars 2 forks source link

Updated the theme for the site, custom version of Bootswatch - Yeti. Wro... #65

Closed Ap0c closed 9 years ago

Ap0c commented 9 years ago

...te some information for the about page. Gave article list and course list pages a facelift. Tidied up and unified the formatting of the articles.

hmac commented 9 years ago

I'd much rather we use system fonts rather than custom ones that have to be loaded from an external site. It adds 3 extra requests and about 30% to the page load time. It also means the site won't display properly when run locally without an internet connection (if that were ever a requirement for any reason).

Also I think body text should be a serif font - makes it a lot easier to read.

Other than that, looks good.

hmac commented 9 years ago

Screenshot for reference: screen shot 2014-09-21 at 02 24 51

drewsberry commented 9 years ago

I prefer the new theme. Also, I feel like the navbar-brand could do with somrthing to indicate we're on the home page, in the same way you use class='active' for the navbar items. Any know of anything as such?

drewsberry commented 9 years ago

Also, I noticed you changed some of the indent to hard tabs from soft, and from 4 to 8. Is there any particular reason for this? I kinda prefer 4 soft tabs

Ap0c commented 9 years ago

I wasn't aware that I'd changed it to 8, it's coming up as 4 in mine. I prefer 4 as well, 8 has always seemed overkill. Are you sure the editor you're using isn't converting hard tabs to 8?

hmac commented 9 years ago

does your flake8 not complain when you put spaces around the equals sign in named arguments?

Ap0c commented 9 years ago

No because I turned that warning off, I don't agree with pep8 on that front. Sorry, if you prefer I didn't do that I'll try to remember not to.

hmac commented 9 years ago

I think the reason for it is otherwise it looks a bit like assignment, which could be confusing

hmac commented 9 years ago

I'm not fussed either way though, it's just flake keeps shouting at me about it

Ap0c commented 9 years ago

Yeah but I find it makes the code look a bit dense when I'm trying to read through it. Drewsberry, what dyou think? Btw, assuming you're using sublime you can go Preferences > Package Settings > SublimeLinter > Settings - User and add the line

"ignore_match": [
    "unexpected spaces around keyword / parameter equals"
],

under flake8 to turn it off.