Version 0.7.8 fails to build

[seahawk1986]

There seems to be an undeclared symbol w in displaymenu.c:

g++ -Wall -g -O3 -Wall -Werror=overloaded-virtual -Wno-parentheses -fPIC -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -std=c++11 -c -DPLUGIN_NAME_I18N='"skinflatplus"' -DVDRLOGO=\"vdrlogo_yavdr\" -DWIDGETFOLDER='"/usr/lib/vdr/plugins/skinflatplus/widgets"' -I/usr/include/uuid -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/GraphicsMagick -o displaymessage.o displaymessage.c
displaymenu.c: In member function 'virtual bool cFlatDisplayMenu::SetItemEvent(const cEvent*, int, bool, bool, const cChannel*, bool, eTimerMatch, bool)':
displaymenu.c:1651:13: error: 'w' was not declared in this scope
 1651 |             w = fontSml->Width("XXX 99. ") + marginItem;
      |             ^
displaymenu.c:1655:13: error: 'w' was not declared in this scope
 1655 |             w = font->Width("XXX 99. ") + marginItem;
      |             ^
displaymenu.c:1659:17: error: 'w' was not declared in this scope
 1659 |         Left += w + marginItem;
      |                 ^
make[1]: *** [Makefile:102: displaymenu.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make[1]: Leaving directory '/build/vdr-plugin-skinflatplus-0.7.8'

It seems that this variable is still used after the if-block starting on line 1497 goes out of scope.

[MegaV0lt]

Should be fixed with https://github.com/MegaV0lt/vdr-plugin-skinflatplus/commit/2f3f7af7ed4272ef2ffe9d9a18b177999e4cb77d

Please test

[M-Reimer]

I just was able to build 0.7.9 for Arch Linux. AUR is updated. But I get a pretty long list with many deprecation warnings. Probably something you should have a look at.

[MegaV0lt]

Can you provide a log?

[seahawk1986]

Should be fixed with 2f3f7af

Please test

Version 0.7.9 built successfully on Ubuntu 22.04: https://launchpadlibrarian.net/695590562/buildlog_ubuntu-jammy-amd64.vdr-plugin-skinflatplus_0.7.9-0yavdr0~jammy_BUILDING.txt.gz - I can't see any warnings there.

With Arch Linux I get deprecation warnings from templated functions defined in the GraphicsMagick library (std::unary_function was deprecated in C++11): https://gist.github.com/seahawk1986/a17a7b591dbb1ae92fc191c43719792f - looks like this needs to be fixed by the GraphicsMagick developers.

[M-Reimer]

Ah. Thanks. Then everything is OK, now.

[MegaV0lt]

Tank you for providing Log and finding the issue.