Megabit / Blazorise

Blazorise is a component library built on top of Blazor with support for CSS frameworks like Bootstrap, Tailwind, Bulma, AntDesign, and Material.
https://blazorise.com/
Other
3.29k stars 531 forks source link

DatePicker DisableMobile not working. Keyboard still opens on selection on Mobile. (Blazorise 1.2.0) #4577

Open Mr-Pearce opened 1 year ago

Mr-Pearce commented 1 year ago

Describe the bug like title. grafik To Reproduce

I Just tested it with the new DisableMobile (My Field is inside A Row and a Modal if this changes anything) And it still behaves like in my original screenshot Tested on Android Huawei P30 Android 10

<Field ColumnSize="ColumnSize.Is12" Margin="Margin.Is0">
    <FieldLabel>Stuff</FieldLabel>
    <FieldBody>
        <Addon AddonType="AddonType.Body">
            <DatePicker @ref="@datePicker" DisableMobile TValue="DateTime?" @bind-Date="@Date" Placeholder="Stuff" DisplayFormat="MM.yy" InputMode="DateInputMode.Date" Min="@MinDate">

            </DatePicker>
        </Addon>
        <Addon AddonType="AddonType.End">
            <Button Color="Color.Danger" Clicked="@(()=>DoStuff= null)">
                <Icon Name="IconName.Delete" />
            </Button>
        </Addon>

    </FieldBody>
</Field>

Expected behavior Keyboard should be hidden.

stsrki commented 1 year ago

I believe the problem might be in how flatpickr detect the mobile device. This is their code /Android|webOS|iPhone|iPad|iPod|BlackBerry|IEMobile|Opera Mini/i.test(navigator.userAgent). The DisableMobile works without issues when I test it on my machine. So my guess is that the browser on Android Huawei P30 Android 10 have a different userAgent name.

Could you try running the following on your machine?

function isMobile() {
    return /Android|webOS|iPhone|iPad|iPod|BlackBerry|IEMobile|Opera Mini/i.test(
        navigator.userAgent
    );
}

Or console.log(navigator.userAgent) to find out the real name? That will help us, any maybe we can contribute it to the flatpickr after fixing it.

Mr-Pearce commented 1 year ago

I Tested it with

@code {
    [Inject] IHttpContextAccessor httpContextAccessor { get; set; }

    string useragent;
    protected override Task OnInitializedAsync()
    {
        useragent = httpContextAccessor.HttpContext.Request.Headers.UserAgent;

        return base.OnInitializedAsync();
    }
}

Tested with Blazorise 1.2 so the keyboard is still opening.

P30 with Opera IsMobile = False Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/108.0.5359.215 Safari/537.36 OPR/94.0.4606.65

Chrome IsMobile = True Mozilla/5.0 (Linux; Android 10; ELE-L29) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/110.0.0.0 Mobile Safari/537.36

Another device (Android 11) With an Hardware Barcode Scanner and an own browser(Based on Chrome i think) own browser IsMobile = True Mozilla/5.0 (Linux; Android 11; C66 Build/RKQ1.201202.002; wv) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/108.0.5359.128 Mobile Safari/537.36

Chrome IsMobile = True Mozilla/5.0 (Linux; Android 11; C66) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/108.0.0.0 Mobile Safari/537.36

stsrki commented 1 year ago

Thank you

stsrki commented 1 year ago

As I suspected there is no mention of anything mobile for P30

P30 with Opera Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/108.0.5359.215 Safari/537.36 OPR/94.0.4606.65

Only X11. Is that an android version?

stsrki commented 1 year ago

@Mr-Pearce can you run this on your mobile to test it?

/(android|bb\d+|meego).+mobile|avantgo|bada\/|blackberry|blazer|compal|elaine|fennec|hiptop|iemobile|ip(hone|od)|iris|kindle|lge |maemo|midp|mmp|mobile.+firefox|netfront|opera m(ob|in)i|palm( os)?|phone|p(ixi|re)\/|plucker|pocket|psp|series(4|6)0|symbian|treo|up\.(browser|link)|vodafone|wap|windows ce|xda|xiino/i.test(navigator.userAgent) || /1207|6310|6590|3gso|4thp|50[1-6]i|770s|802s|a wa|abac|ac(er|oo|s\-)|ai(ko|rn)|al(av|ca|co)|amoi|an(ex|ny|yw)|aptu|ar(ch|go)|as(te|us)|attw|au(di|\-m|r |s )|avan|be(ck|ll|nq)|bi(lb|rd)|bl(ac|az)|br(e|v)w|bumb|bw\-(n|u)|c55\/|capi|ccwa|cdm\-|cell|chtm|cldc|cmd\-|co(mp|nd)|craw|da(it|ll|ng)|dbte|dc\-s|devi|dica|dmob|do(c|p)o|ds(12|\-d)|el(49|ai)|em(l2|ul)|er(ic|k0)|esl8|ez([4-7]0|os|wa|ze)|fetc|fly(\-|_)|g1 u|g560|gene|gf\-5|g\-mo|go(\.w|od)|gr(ad|un)|haie|hcit|hd\-(m|p|t)|hei\-|hi(pt|ta)|hp( i|ip)|hs\-c|ht(c(\-| |_|a|g|p|s|t)|tp)|hu(aw|tc)|i\-(20|go|ma)|i230|iac( |\-|\/)|ibro|idea|ig01|ikom|im1k|inno|ipaq|iris|ja(t|v)a|jbro|jemu|jigs|kddi|keji|kgt( |\/)|klon|kpt |kwc\-|kyo(c|k)|le(no|xi)|lg( g|\/(k|l|u)|50|54|\-[a-w])|libw|lynx|m1\-w|m3ga|m50\/|ma(te|ui|xo)|mc(01|21|ca)|m\-cr|me(rc|ri)|mi(o8|oa|ts)|mmef|mo(01|02|bi|de|do|t(\-| |o|v)|zz)|mt(50|p1|v )|mwbp|mywa|n10[0-2]|n20[2-3]|n30(0|2)|n50(0|2|5)|n7(0(0|1)|10)|ne((c|m)\-|on|tf|wf|wg|wt)|nok(6|i)|nzph|o2im|op(ti|wv)|oran|owg1|p800|pan(a|d|t)|pdxg|pg(13|\-([1-8]|c))|phil|pire|pl(ay|uc)|pn\-2|po(ck|rt|se)|prox|psio|pt\-g|qa\-a|qc(07|12|21|32|60|\-[2-7]|i\-)|qtek|r380|r600|raks|rim9|ro(ve|zo)|s55\/|sa(ge|ma|mm|ms|ny|va)|sc(01|h\-|oo|p\-)|sdk\/|se(c(\-|0|1)|47|mc|nd|ri)|sgh\-|shar|sie(\-|m)|sk\-0|sl(45|id)|sm(al|ar|b3|it|t5)|so(ft|ny)|sp(01|h\-|v\-|v )|sy(01|mb)|t2(18|50)|t6(00|10|18)|ta(gt|lk)|tcl\-|tdg\-|tel(i|m)|tim\-|t\-mo|to(pl|sh)|ts(70|m\-|m3|m5)|tx\-9|up(\.b|g1|si)|utst|v400|v750|veri|vi(rg|te)|vk(40|5[0-3]|\-v)|vm40|voda|vulc|vx(52|53|60|61|70|80|81|83|85|98)|w3c(\-| )|webc|whit|wi(g |nc|nw)|wmlb|wonu|x700|yas\-|your|zeto|zte\-/i.test(navigator.userAgent.substring(0, 4))

Mr-Pearce commented 1 year ago

@Mr-Pearce can you run this on your mobile to test it?

@stsrki Chrome: True on Both devices

Opera on P30 False,

True on my Hardware Scanner (which is higher priority for me 😅 )

stsrki commented 1 year ago

I am waiting for an external party to fix the issue before merging PR.

David-Moreira commented 1 year ago

@stsrki status on this?

stsrki commented 1 year ago

Still the same.

I am waiting for an external party to fix the issue before merging PR.

David-Moreira commented 2 months ago

@stsrki status update?

stsrki commented 2 months ago

Still no change.