Share button blog - Githubissues

Megabit / Blazorise

Blazorise is a component library built on top of Blazor with support for CSS frameworks like Bootstrap, Tailwind, Bulma, AntDesign, and Material.

https://blazorise.com/

Other

3.18k stars 517 forks source link

Share button blog #5513

Closed ddjerqq closed 1 month ago

ddjerqq commented 1 month ago

Added Share button blog

Closes #4022

How Has This Been Tested?

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality not to work as expected)

Checklist:

[x] The PR is submitted to the correct branch (master for dev, rel-1.x for maintenance).
[x] My code follows the code style of this project.
[ ] I've added relevant tests.

github-actions[bot] commented 1 month ago

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

stsrki commented 1 month ago

It seems rebasing is not an option now. I assume you have created your feature branch from master? It is best to close the PR and recreate it starting from rel-1.5 branch, not the master.

ddjerqq commented 1 month ago

I have read the CLA Document and I hereby sign the CLA

ddjerqq commented 1 month ago

I forgot to mention. Blogs go into current production branch(rel-1.5) so that we can release them without breaking documentation version. I will rebase it now.

Will consider this for future blogs! Thanks for the heads up!

stsrki commented 1 month ago

I forgot to mention. Blogs go into current production branch(rel-1.5) so that we can release them without breaking documentation version. I will rebase it now.

Will consider this for future blogs! Thanks for the heads up!

It needs to also go now into rel-1.5 since master is only for new development.

I will close the PR and you can open new that targets the right branch.