Megabit / Blazorise

Blazorise is a component library built on top of Blazor with support for CSS frameworks like Bootstrap, Tailwind, Bulma, AntDesign, and Material.
https://blazorise.com/
Other
3.32k stars 535 forks source link

Video: Disable Fullscreen #5775

Closed thumaman closed 1 month ago

thumaman commented 1 month ago

Hi,

is there any way to disable the video to enter fullscreen if a user double taps on a video.

stsrki commented 1 month ago

Not at the moment. But it can be done by adding new API https://www.vidstack.io/docs/player/components/core/player#mediaplayer.dataattrs.data-can-fullscreen

I will make it for 1.7

stsrki commented 1 month ago

When you assume that it will be easy...

It turns out it is not possible.

Image

and

Image


Even if we define canFullscreen it is not guaranteed to work. I'm testing it locally, and for me, it doesn't work. Now, I could push these changes, and you could use them, but be aware that it will have some limitations.

I will try to open a ticket on Vidstack and see what they have to say about it.

stsrki commented 1 month ago

https://github.com/vidstack/player/discussions/1470

stsrki commented 1 month ago

I was able to find the right option.

https://github.com/Megabit/Blazorise/pull/5776

thumaman commented 1 month ago

Great,

thank you for your help.

When will these changes be available? In 1.7. release?

stsrki commented 1 month ago

The plan was for Oct 15th, but since we still have some outstanding tickets, we will postpone it by a few more days.

thumaman commented 1 month ago

Got it!

Thanks again.

thumaman commented 1 month ago

Is this functionality available in 1.6.2?

stsrki commented 1 month ago

No, in 1.7 only. You can see the milestones on the sidebar of each task. That way, you can know which release it will be released next.

thumaman commented 1 month ago

Would it be possible to release it sooner since it is a very minor change?

stsrki commented 1 month ago

Yes, I have released a 1.7 preview now. Please try it.