Megagig / shopmaster

An eCommerce web application designed to offer a wide range of products to customers. The platform provides users with a seamless shopping experience, including advanced search capabilities, secure transactions, and instant product payments. Built with a modern tech stack to ensure scalability, responsiveness, and user-friendly navigation.
https://shopmaster.vercel.app
0 stars 1 forks source link

Cart #15

Closed AYOPELUMI closed 1 month ago

AYOPELUMI commented 1 month ago
Divinechi commented 1 month ago

Approved.

On Mon, Jun 24, 2024 at 12:31 AM AYOPELUMI @.***> wrote:

@AYOPELUMI https://github.com/AYOPELUMI requested your review on: #15 https://github.com/Megagig/shopmaster/pull/15 Cart.

— Reply to this email directly, view it on GitHub https://github.com/Megagig/shopmaster/pull/15#event-13258472590, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZFWDDMZVB47SCLP5R23FRTZI5LG3AVCNFSM6AAAAABJYY2WDOVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJTGI2TQNBXGI2TSMA . You are receiving this because your review was requested.Message ID: @.***>

Megagig commented 1 month ago

@Divinechi I am sorry we cannot merge your work into the development branch. This is because your styling has affected the initial work carried out on the project. Have a look at the screenshot of your styles.

Screenshot from 2024-06-25 07-53-26

I have disabled the ability for anyone to merge pull requests. imagine what could have happened if this pull request is merged without review. it will just revert us to square one.

Screenshot from 2024-06-25 07-55-13

Screenshot from 2024-06-25 07-55-48

Screenshot from 2024-06-25 07-56-47

Please don't merge this pull request. Thanks

Megagig commented 1 month ago

@iyke-e I saw the commit on tailwind config file which you pushed. This is to bring to your notice that the styling errors are not yet sorted out. Please kindly implement this. If you are having issues that you cannot solve, reach out to team members to help you get unstuck

iyke-e commented 1 month ago

Noted we're working on it

Megagig commented 1 month ago

@Divinechi @AYOPELUMI @iyke-e

Weldone, on your awesome work.

Project is approved as agreed by the reviews during the call today.

congratulations