MegaphoneJon / com.jlacey.electoral

Other
2 stars 3 forks source link

Changing `council_district` to `ward` in 298 in GoogleCivicInformation.php #1

Closed joemcl closed 4 years ago

joemcl commented 4 years ago

A "fix" for #26 , it's not a permanent fix, but it will allow me to get the correct value for Wards for cities like Santa Ana, CA; Chicago, IL that have wards as the OCDID name not council_districts as NYC does. I think :).

joemcl commented 4 years ago

I can't file Issues here, but the error I am getting is:

Notice: Undefined offset: 1 in google_civic_information_city_districts() (line 298 of /var/www/joe-demo/htdocs/sites/all/civicrm-custom/extensions/com.jlacey.electoral/api/v3/GoogleCivicInformation.php).

and that line was:

substr($divisionParts[1], 0, 16) == 'council_district' &&,

and this changes council_district to ward.

joemcl commented 4 years ago

OK never mind, this doesn't change anything, even after changing the other occurrence of council_district I missed in line 229 or so.