Closed Ayouuuu closed 3 months ago
Is there any server software that returns a value without the SNAPSHOT?
Is there any server software that returns a value without the SNAPSHOT?
You are right, but when getBukkitVersion() return 1.17-R0.1-xxx-SNAPSHOT
or 1.17-R0.1-SNAPSHOT-xxx
, 1.17-R0.2-SNAPSHOT
scoreboard-library will not work.
I guess everything after the first "-" could be cut out, but what software even returns values like that?
I guess everything after the first "-" could be cut out, but what software even returns values like that?
when someone change this or use a custom server with a changed version https://github.com/PaperMC/Paper/blob/master/gradle.properties#L2
should be fixed in cf8fa59c860c48343993758bf618c4d23c9d18d2
https://github.com/MegavexNetwork/scoreboard-library/blob/96595d0a41bea636c33da166f5461d78b4ab5d48/implementation/src/main/java/net/megavex/scoreboardlibrary/implementation/PacketAdapterLoader.java#L45-L63
I think instead of just loading the SNAPSHOT version, this won't work when using other non-SNAPSHOT, so we should check the server version like