Meghthedev / Releases

4 stars 16 forks source link

Consider to Signed The Rom with release key and Rename kernel #1

Open reypryma opened 4 months ago

reypryma commented 4 months ago

The Releases Where Issue Happens

this oppo a37 lineage release

The problem

Due of device check by google, now RCS doesn't work

What was the expected behavior to fix?

I am in no way understand kernel and rom, so please apologize if I make mistakes but I hope the full picture is understandable. With the latest integrity check, take look at thread in xdaforum, from this post google start to check the device integrity by checking -uname if kernel is contained banned name (which the oppo a37 custom rom that you developed contains that banned name).

lineage-name-banned

Also I checked the otacerts located in /system/etc/security/otacerts is signed with test key, normally, official lineageOS ROM and popular Custom ROMs like Xiaomi Community signed with release key.

Please consider to sign the build rom with release key, since this will increase the possibility of RCS function to work (the RCS now doesn't work in your oppo a37 custom rom because signed build rom issue, and maybe in the future google will start limiting more features for banned kernel and test signed build ROM).

I hope you consider in the next release to remove the lineage text in kernel name, maybe randomize? For the sake of “not being too obvious to google” and also signing the ROM not with testkey.

here the reference for removing banned name (?) https://github.com/kerneltoast/android_kernel_google_zuma/commit/a62571e716a930af141280be2c101bf07e551503 https://github.com/arter97/android_kernel_nothing_sm8475/commit/8861034724c6ec4680dbd68a3ce742f4b53e7078 https://github.com/DD3Boh/android_kernel_nubia_sm8250/pull/1/files

Also reference to signing build ROM https://wiki.lineageos.org/signing_builds#generating-the-install-package https://github.com/osm0sis/PlayIntegrityFork?tab=readme-ov-file#failing-device-verdict-on-custom-rom

Sorry if the link I provide didn’t help at all, but some of it references that help to understand why the addressed issue created. Thank you for your hardwork of maintaining and develop this smooth custom rom

realyukii commented 3 months ago

Hi @reypryma , Did you find any workaround to resolve this issue? I'm new to custom ROMs and don't have experience with building or maintaining them.

I tried to locate where the lineageos string is found in the Oppo repository.

$  grep -e "lineageos" -R .
./BoardConfig.mk:TARGET_KERNEL_CONFIG := lineageos_a37f_defconfig

but unfortunately can't find the kernel name string :"

realyukii commented 3 months ago

Hi @Meghthedev Do you have any notes or documentation on building a custom ROM for specific, unofficial devices? it would be very helpful and I would very appreciate that ^^

I know it will take some time and effort for me to get the hang of this, but I’m really excited to dive into custom ROM development :smile_cat:

Meghthedev commented 3 months ago

Hi @reypryma , Did you find any workaround to resolve this issue? I'm new to custom ROMs and don't have experience with building or maintaining them.

I tried to locate where the lineageos string is found in the Oppo repository.

$  grep -e "lineageos" -R .
./BoardConfig.mk:TARGET_KERNEL_CONFIG := lineageos_a37f_defconfig

but unfortunately can't find the kernel name string :"

@RealYukiSan kernel name string is in kernel/oppo/msm8939/Makefile , you should join the telegram group and ask deepak sir, he will guide

Meghthedev commented 3 months ago

The Releases Where Issue Happens

this oppo a37 lineage release

The problem

Due of device check by google, now RCS doesn't work

What was the expected behavior to fix?

I am in no way understand kernel and rom, so please apologize if I make mistakes but I hope the full picture is understandable. With the latest integrity check, take look at thread in xdaforum, from this post google start to check the device integrity by checking -uname if kernel is contained banned name (which the oppo a37 custom rom that you developed contains that banned name).

lineage-name-banned

Also I checked the otacerts located in /system/etc/security/otacerts is signed with test key, normally, official lineageOS ROM and popular Custom ROMs like Xiaomi Community signed with release key.

Please consider to sign the build rom with release key, since this will increase the possibility of RCS function to work (the RCS now doesn't work in your oppo a37 custom rom because signed build rom issue, and maybe in the future google will start limiting more features for banned kernel and test signed build ROM).

I hope you consider in the next release to remove the lineage text in kernel name, maybe randomize? For the sake of “not being too obvious to google” and also signing the ROM not with testkey.

here the reference for removing banned name (?) https://github.com/kerneltoast/android_kernel_google_zuma/commit/a62571e716a930af141280be2c101bf07e551503 https://github.com/arter97/android_kernel_nothing_sm8475/commit/8861034724c6ec4680dbd68a3ce742f4b53e7078 https://github.com/DD3Boh/android_kernel_nubia_sm8250/pull/1/files

Also reference to signing build ROM https://wiki.lineageos.org/signing_builds#generating-the-install-package https://github.com/osm0sis/PlayIntegrityFork?tab=readme-ov-file#failing-device-verdict-on-custom-rom

Sorry if the link I provide didn’t help at all, but some of it references that help to understand why the addressed issue created. Thank you for your hardwork of maintaining and develop this smooth custom rom

@reypryma im busy for some time . Once I find time I might build with these changes

realyukii commented 3 months ago

kernel name string is in kernel/oppo/msm8939/Makefile

Which repository? I can't find it on your repository

you should join the telegram group and ask deepak sir, he will guide

It seems the group is less active nowadays

Meghthedev commented 2 months ago

kernel name string is in kernel/oppo/msm8939/Makefile

Which repository? I can't find it on your repository

you should join the telegram group and ask deepak sir, he will guide

It seems the group is less active nowadays

That repo is the device tree ( cloned to path device/oppo/A37, you need to use the kernel tree for name change, that's probably in my gitlab profile iirc, gitlab.com/Meghthedev, there will be a kerneloppo.. repo, your needed file will be there. Also, group is not active, can't do anything about it