Switch libraries & reduce duplicated code

MeguminSama / discord-slash-commands

Node.JS Slash Commands for Discord

MIT License

100 stars 15 forks source link

Switch libraries & reduce duplicated code #4

Closed GamingGeek closed 3 years ago

GamingGeek commented 3 years ago

This PR;

Switches node-fetch to centra as it's been proven to be faster
Switches noble-ed25519 to tweetnacl as it's more popular and has been audited
Reduces the amount of duplicated code by having a guildId parameter rather than separate functions and uses create for edit too since it's the same endpoint

MeguminSama commented 3 years ago

Thanks for the PR!

A5rocks commented 3 years ago

Also, thanks for tweetnacl, I was having trouble with noble-ed25519's use of BigInts and Cloudflare Worker's default webpack configuration. (Though at this point I'm using tweetnacl but exported, see @stablelib/ed25519 :P)