Implement `KNIFE` EnchantmentCategory using Fabric-ASM - Githubissues

MehVahdJukaar / FarmersDelight

A lightweight farming expansion for Minecraft.

MIT License

16 stars 11 forks source link

Implement `KNIFE` EnchantmentCategory using Fabric-ASM #24

Closed RaymondBlaze closed 3 months ago

RaymondBlaze commented 3 months ago

As the title stated, this PR provides an implementation for FD's custom KNIFE EnchantmentCategory using Fabric-ASM.

Changes

Restored the KNIFE field in ModEnchantments so addons may use it for custom knife enchantments.
Removed BackstabbingEnchantment#canEnchant, which shall prevent possible conflicts with mod that modifies the Enchantment class.
Introduced Fabric-ASM dependency, currently bundled using jar in jar.

MerchantPug commented 3 months ago

Looks good to me!