MehVahdJukaar / FarmersDelightRefabricated

A lightweight farming expansion for Minecraft.
MIT License
32 stars 18 forks source link

Darker than expected textures on almost all crops #41

Closed FlashOfAsh closed 2 months ago

FlashOfAsh commented 6 months ago

Minecraft version

1.20.1

Farmer's Delight version

2.0.17

Fabric Loader version

0.15.7

Fabric API version

0.92.0+ 1.20.1

Description

Almost all crops (except tomatoes) have a seemingly darker than usual texture that doesn't fit with most other minecraft crops, including mushrooms

Picture Examples: Red Mushroom image Brown Mushroom (maybe the least noticeable? at least the light level they give off is right) image Main Farm picture 1 image Main Farm picture 2 image

Steps to reproduce

1: Plant crop that isn't tomato (if mushroom wait until it starts becoming a colony) 2: see it

Mod list

Logs

No response

Minimal instance

Performance and shader mods

MerchantPug commented 6 months ago

Strange, I'll look at the Forge version and see if it's an issue there.

MerchantPug commented 6 months ago

Okay, Forge version has the intended behavior. I'll see what I can do about this.

MerchantPug commented 6 months ago

image Hi, I'm unable to reproduce. This is likely an issue caused by another one of your mods.

FlashOfAsh commented 6 months ago

strange, but i mean, alright, maybe iris or sodium are doing something to it somehow

HaXrDEV commented 5 months ago

Had the same issue with Regions Unexplored, and found out it was caused by Create Fabric due to porting lib overriding the render material. Could very well be related as i see you have Create Fabric in your mod list: https://github.com/Fabricators-of-Create/Create/issues/1259

FlashOfAsh commented 5 months ago

Had the same issue with Regions Unexplored, and found out it was caused by Create Fabric due to porting lib overriding the render material. Could very well be related as i see you have Create Fabric in your mod list: Fabricators-of-Create/Create#1259

that does sound very plausible

MerchantPug commented 4 months ago

Had the same issue with Regions Unexplored, and found out it was caused by Create Fabric due to porting lib overriding the render material. Could very well be related as i see you have Create Fabric in your mod list: Fabricators-of-Create/Create#1259

Porting Lib is also used here, so I'd imagine that this with Iris alone could recreate the issue.

MerchantPug commented 4 months ago

It's apparently fixed on Porting Lib's end, we'll update our included PL modules as soon as we can.

MehVahdJukaar commented 2 months ago

confirmed that its caused by porting lib. doesnt happen with just FD on since we are not using the module that causes this. Adding stuff like create fabric which includes that module causes this issue. Closing since not our issue