MehVahdJukaar / JustEnoughEffectDescriptions

Other
8 stars 16 forks source link

[Suggestion] Mob effect item scroll #58

Open Cicopath opened 2 months ago

Cicopath commented 2 months ago

Suggestion 1 At the moment, the item cycling of all items that give the respective effect is way too fast, about one cycle every second. This doesn't give players enough time to actually read about the item without having to wait for the item to appear and search for the item themselves in the JEI/REI/EMI menu.

It would be extraordinarily beneficial if players were allowed to scroll through the items instead, whether vertically or horizontally. This would make it so much easier to see every item that gives the effect!

Suggestion 2 There are some mods whose items are not being considered due to certain NBT tags. Most notably:

I actually don't know who is supposed to add compatibility, whether you or the respective mod. Regardless, this compatibility would be greatly beneficial!

I hope you take these into consideration. Thank you!

MehVahdJukaar commented 2 months ago

ill see if i can do somethin g for the scrollbar. The cycling itself is handled by the recipe viewer mod directly, its same effect that occurs when it shows you items in a tab. As for compatibility its really something that the target mod should add. I added some recipes internally myself but i can do that for all mods, especially the ones im not familar with. Mods can just add a simple JEED recipe for their items

Cicopath commented 2 months ago

Sounds good!

The only reason I mentioned compatibility with the other mods is because I noticed anything NBT-related, like potions and tipped arrows, always come after the items that are added via the jeed:effect_provider recipe type. I'm looking to keep this consistency by putting any modded items with NBTs that act similar to potions at the end of the list rather than at the start. It's not at all a big deal, just... perfectionism, I suppose, lol.

I haven't worked with adding NBT items using JEED's custom recipe type. would it work something like this? (just an example):

{
  "type": "jeed:effect_provider",
  "effect": "minecraft:water_breathing",
  "providers": [
    {
      "fabric:type": "fabric:nbt",
      "base": {
        "item": "minecraft:potion"
      },
      "nbt": "{\"Potion\": \"minecraft:water\"}",
      "strict": "true"
    }
  ]
}

This would not only help me for my modpack, but also creating pull requests to add compatibility with JEED for other mods

Cicopath commented 2 months ago

Was able to figure out how to add NBT compatibility. Changed the post name to focus on the scroll suggestion only.