MehVahdJukaar / Randomium

2 stars 7 forks source link

all Randomium ores only drops luck potions #13

Closed GizmoTheMoonPig closed 1 year ago

GizmoTheMoonPig commented 1 year ago

Minecraft version: 1.19.4 Forge Version: 45.0.41 Randomium version: 1.19.4-1.20

Title says all. I've mined a total of 8 randomium so far in my world and have only gotten luck potions. Tested in a creative world and had the same issue. I didnt look super close into it, but I assume items from tabs arent actually being added to the loot list (done here: https://github.com/MehVahdJukaar/Randomium/blob/1.20/common/src/main/java/net/mehvahdjukaar/randomium/Randomium.java#L105-L124)

MehVahdJukaar commented 1 year ago

I think tabs are initialised later now so that code runs too early. I'll have to rethink that

GizmoTheMoonPig commented 1 year ago

updated the mod to 1.22 and im still having this problem. Looks like the code still runs early only on forge, and because the list is never actually empty (which it checks for here) the loot still only contains luck potions

GizmoTheMoonPig commented 1 year ago

updated the mod to 1.23 (I did this a while ago, but forgot to report), and well, now the ores drop nothing at all. No luck potions or anything.

GizmoTheMoonPig commented 1 year ago

I finally got around to actually investigating the issue. Apparently tabs dont even initialize until you open the creative inventory, so theyll NEVER even exist in survival mode. 1.20 should hopefully change this since tabs are gonna become a proper registry in that version

MehVahdJukaar commented 1 year ago

Oh darn what the hell