[🐞]: Stasis can be applied on crossbows, to many stasis books in end-cities

ghost commented 2 months ago

Before Continuing:

[X] Check you are using the latest version of the mods and its dependencies
[X] Always include a latest.log if you are crashing
[X] Remove mod that enhances Minecraft: Optifine, Sodium, others. The issue persists.
[X] If you are unsure which mod is the culprit. Disable all of your mods and enable them 1-2 mods each time to isolate the culprit
[X] Confirm that there is no existing issue with a similar description submitted in the list of issues.

Version

1.20.1-FABRIC

Supplementaries Version

supplementaries-1.20-2.8.10-fabric

Moonlight Lib Version

moonlight-1.20-2.11.12-fabric

Issue Detail

Stasis can be applied to crossbows using anvils, also there seems to be a pretty high chance for stasis-books to be found in end cities making it not rare at all.

Would be awesome if you have some time to look into it ^^

Kind regards, Ranni

MehVahdJukaar commented 2 months ago

Fabric does not have an enchantment API. This is the only way it can be done. Use forge for better features. Stasis chance is 1/3 in end cities. Considering end cities are rare and the end itself is rare I think it's one of the rares enchantments that there are

Hex4dec commented 2 months ago

This is not the only way it can be done. With some mixins to EnchantmentTarget, I'm pretty sure you could fix this issue.

MehVahdJukaar commented 2 months ago

Feel free to PR

MehVahdJukaar / Supplementaries