MehVahdJukaar / Supplementaries

Other
145 stars 106 forks source link

[🐞]: Antique Ink cannot be used on non-directional Signs #1062

Open sapphiriza opened 5 months ago

sapphiriza commented 5 months ago

Before Continuing:

Version

1.20.1-FABRIC

Supplementaries Version

Supplementaries-1.20-2.8.10

Moonlight Lib Version

1.20-2.11.33

Issue Detail

Attempting to use the Antique Ink on a sign will instead open the GUI for editing the sign text. It does work on directional signposts on fences, but does not work on vanilla signs or hanging signs.

MehVahdJukaar commented 5 months ago

this is more of amissing feature. antique ink is mostly a forge only feature as it relies on forge block entity capabilityes. Might be a while until i look into this

sapphiriza commented 5 months ago

Oh ok, it's weird that it does work on the directional signs... seems like it's just that the edit-sign-contents GUI is interrupting the antique ink interaction?

MehVahdJukaar commented 5 months ago

By directional signs you mean vanilla floor signs?

VitaminJake commented 5 months ago

No he means the ones that attach to a signpost, which I had assumed were added by supple. I also have a very vested interest in this. *Edit they are added by your mod, so it works with the signs from your mod just not vanilla standing or hanging signs, nor any other modded signs such as betternether etc. Base Profile Screenshot 2024 06 12 - 07 50 46 57

MehVahdJukaar commented 5 months ago

yeah those are called way signs and of course they wokr as they are added by the mod and dont rely on attatched tile entity capabilities like normal ones do. As ive said i might look into ways to add that for fabric but thats low priority now