MehVahdJukaar / Supplementaries

Other
137 stars 96 forks source link

[🐞]: capture_blacklist tag not working as intended, wrong ids? #1072

Open LeonarthCG opened 3 months ago

LeonarthCG commented 3 months ago

Before Continuing:

Version

1.20.1-FORGE

Supplementaries Version

supplementaries-1.20-2.8.15

Moonlight Lib Version

moonlight-1.20-2.11.41-forge

Issue Detail

capture_blacklist.json has a few entries for segmented mobs from Alex's Mobs. It is meant to prevent their capture, as it leads to issues because of the way the mobs are implemented.

Perhaps this used to work, but with the current version of Alex's Mobs (1.22.8) the blacklist is not effective. The blacklist itself is being applied, but the mob ids it includes do nothing.

I tested this by creating a modpack with just Alex's Mobs and Supplementaries (plus dependencies), enabling cage_auto_detect and trying to cage a cave centipede. The blacklist should prevent it from being captured, but it does not, so the centipede (or, rather, a segment) gets caged. I then replaced the id alexsmobs:centipede with alexsmobs:centipede_body and this time it did prevent capture of the centipede (segment).

I did a similar test with the anaconda. In this case, the blacklist does prevent the head (with id alexsmobs:anaconda) from being caged, but it does not do the same for the body, as the id for the body is alexsmobs:anaconda_part.

So, in short, I think the blacklist entries are not working as intended and need to be replaced with entries for each body segment of the respective mobs.

I believe the resulting json would look like this:

{
  "replace": false,
  "values": [
    {"id":"alexsmobs:centipede_head","required":false},
    {"id":"alexsmobs:centipede_body","required":false},
    {"id":"alexsmobs:centipede_tail","required":false},
    {"id":"alexsmobs:bone_serpent","required":false},
    {"id":"alexsmobs:bone_serpent_part","required":false},
    {"id":"alexsmobs:void_worm","required":false},
    {"id":"alexsmobs:void_worm_part","required":false},
    {"id":"alexsmobs:anaconda","required":false},
    {"id":"alexsmobs:anaconda_part","required":false},
    {"id":"alexsmobs:murmur","required":false},
    {"id":"alexsmobs:murmur_head","required":false}
  ]
}

I did not test every mob, but those are the mob ids I have been using on my modpack to prevent other capturing methods for these mobs.