[❓]: Custom adventurer map via Data Pack

kkempfer commented 3 months ago

Your Question

What am I doing wrong to setup custom adventurer maps via a data pack ?

Detail

I am making a modpack using the following configuration:

Minecraft 1.19.2 Loader: Fabric 0.15.11 Supplementaries: 2.4.21-fabric (latest) MoonLight Lib: 2.3.6-fabric (latest)

I struggle to setup custom adventurer maps. I carefully read the wiki:

At this stage, I do not know if there is a bug or not, thus my question: What am I doing wrong ?

Mod configuration: If I turn off the first option following the tooltip recommendation when one wants to use custom adventurer maps, the cartographer does not sell any adventurer maps anymore. If I turn if on, the cartographer sells the default maps.

My datapack structure: I confirmed in-game that my datapack has been loaded.

Content of igloo.json:

{
    "structure": "minecraft:igloo",
    "villagerLevel": 2,
    "mapMarker": "supplementaries:igloo"
}

I confirm that the issue persists if I only use Supplementaries (+ dependencies: MoonLight Lib, Fabric API) and get rid of all the other mods in the modpack.

Can you help me out ?

Cheers

MehVahdJukaar commented 3 months ago

From a glance that seems right. The mod should print something in console when it loads those. Does it do that?

kkempfer commented 3 months ago

Thank you for your quick reply ! I believe it did. See details below.

I did a fresh install on a new instance to reproduce the issue on a minimal setup.

1-fresh-install: I only added Supplementaries and its dependencies. I kept the Supplementaries configuration to its default values. I created a new world and summoned a few Lvl2 cartographer. As expected, they sell adventurer maps using your default structure maps.

2-added-datapack: I added my datapack in my world datapacks directory and turned the "random_adventurer_maps" option to False in supplementaries-common.json. I summoned new cartographers. None of them sold adventurer maps. Extract from the log:

[09:46:52] [Render thread/INFO]: Found new data pack Supplementaries Generated Pack, loading it automatically
[09:46:52] [Render thread/INFO]: Found new data pack file/adventurer-maps, loading it automatically
[09:46:52] [Render thread/INFO]: Generated runtime SERVER_DATA for pack Supplementaries Generated Pack in: 70 ms

3-added-datapack-random-maps-true: I turned the "random_adventurer_maps" option to True. The behaviour is now the same as for 1-fresh-install. The mod does not seem to use my datapack.

Attached all the relevant files: results.zip

NB: Sometimes, the cartographer sells air. I did not investigate much yet, as I believe this is another minor issue. Maybe, it didn't find any suitable structure around the player.

MehVahdJukaar commented 3 months ago

no if it sells air that confirms the trade is working

MehVahdJukaar commented 3 months ago

once it rolls a map trade but the map points to a structure that it cant be found the trade ails and it has an empty trade instead. this happens in vanilla aswell

kkempfer commented 3 months ago

Yes, exactly, thanks for confirming. I just mentioned the "air" sell for reference. I am not concerned about this.

In my test case "2-added-datapack" where I added my datapack and turned off the "random_adventurer_maps" option to False in supplementaries-common.json, the cartographer does not sell any adventurer map at all (nor air), even though it should either sell me "village" or "igloo" adventurer maps (or air) given the content of the datapack (minimal setup for testing).

kkempfer commented 2 months ago

Did you have a chance to look at the issue ? I feel it's a bug. Should we escalate this ticket as a bug ? Cheers,

MehVahdJukaar / Supplementaries

[❓]: Custom adventurer map via Data Pack #1085

Your Question

Detail