MehVahdJukaar / Supplementaries

Other
124 stars 91 forks source link

[🐞]: Several Post Effects (shaders) are immediately removed when `mob_head_shaders` is enabled. #1088

Open mortuusars opened 4 days ago

mortuusars commented 4 days ago

Before Continuing:

Version

1.20.1-FORGE

Supplementaries Version

supplementaries-1.20-2.8.17

Moonlight Lib Version

moonlight-1.20-2.12.6-forge

Issue Detail

If the shader, that is defined in ClientEvents#EFFECTS_PER_ITEM, is applied but player is not wearing the appropriate head - effect is immediately removed. This breaks mods that apply that shader for their purposes.

It was reported to my mod (Exposure) because in latest version I've added a filter that uses vanilla invert shader. I'll fix this particular issue by creating my own invert shader instead, but since filters for Exposure can be created/modified in a resourcepack - players might run into the same problem when using creeper or desaturate shaders, for example. And other mods can potentially be affected by this as well.

MehVahdJukaar commented 3 days ago

I've changed the code a bit. hopefully this should catch this