MehVahdJukaar / Supplementaries

Other
138 stars 97 forks source link

Fabric 1.19.2 Cage delete NBT from Allay's, Allay's don't tag anymore with Note Blocks #525

Closed suerion closed 1 year ago

suerion commented 1 year ago
  1. Catch an Allay with Cage
  2. Let the allay free from the Cage
  3. Try to tag the allay with the note block

We had tested a lot, how the issue is reproducable. the problem appears only with catched Allay in an cage.

MehVahdJukaar commented 1 year ago

Do you know what part of NBT isn't persisting? Seems weird as cages saves an entity with its own save method

suerion commented 1 year ago

Sorry we don‘t know whats the right NBT tag, but something will be blocked to change it again. The allay does not tag to the note block,

i will try to reproduce it with an NBT Explorer

suerion commented 1 year ago

Hey, @MehVahdJukaar i had tried to reproduce the issue.

  1. thing what i had tried, ALLAY TAGED on Noteblock, then catched in Cage, after this, let it free and tried to TAG again, then ther is no Problem, On the NBT it only changed 1 thing -> the Value from PersistenceRequired is changed after the cage to 1. on Vanila, it does not allay

  2. summoned a ALLAY, catched in a Cage, let it free and tried to TAG on the Noteblock, -> Allay save in the Memory, but don't register the Noteblock anymore On NBT it has only Changed again 1 thing -> PersistenceRequired is after catching in the cage to 1. allay1

I think the allay will only works with the Noteblock, if the PersistenceRequired is 0. in the NBT Tags, this is the only Thing, what is changed after catching the allay with the supplementary cage

MehVahdJukaar commented 1 year ago

Oh that all makes sense. I'll update accordingly. The prrisstance was so some mobs don't respawn after you catch them

suerion commented 1 year ago

@MehVahdJukaar is fixed, with the newest update ;) thanks a lot, we had tested it

MehVahdJukaar commented 1 year ago

awesome