search

MehVahdJukaar / Supplementaries

Other
140 stars 99 forks source link

[Quilt 19.2] Seeds not compostable #640

Open Shibva opened 1 year ago

Shibva commented 1 year ago

The issue here is quite simple, Flax seeds for some reason are not compostable; guessing that part was forgotten or some part of the code broke

that is all, should overall be a quick fix

MehVahdJukaar commented 1 year ago

whats your mod version?

Shibva commented 1 year ago

supplementaries-1.19.2-2.3.17-fabric.jar

Shibva commented 1 year ago

It's been like this for a while so I'm surprise no one has reported it before me

MehVahdJukaar commented 1 year ago

I did try it yesterday and it was working for me

Shibva commented 1 year ago

Maybe it's because I'm using the quilt… Strange w why it's doing that thou

Shibva commented 1 year ago

Quilts API does it supposed to be very similar to fabrics to allow for backwards compatibility with fabric mods

if you need to do something different for it let me know, and I might bring it up with their api

MehVahdJukaar commented 1 year ago

As far as I know for compostable you just add stuff to the composter map directly. That's a vanilla thing I don't think there's any API for it and even if there was it should be compatible with the vanilla way. Bur that's likely it. Quilt claim that it works with fabric mod is their claim and could be a bit of a bold one as code is different so minor things might be different enough to cause discrepancies

Shibva commented 1 year ago

I can give it a try when I have a time; I just need to know what I need to do to add something to the composter through a data pack, if that's possible

Or you can try to fix it… To be honest, I'm not sure what youll chose because I read your last Changelog, and you said that you don't wanna touch this sort of version ever again; yet again, I may be missing sarcasm, like I tend to do

Shibva commented 1 year ago

So I found a mod whose code is open-source and has compostable items that work both in fabric and quilt

https://github.com/0rc1nus/Galosphere-Main/blob/ff2716c789022ff133690e4deebbe8bbc597b636/src/main/java/net/orcinus/galosphere/init/GVanillaIntegration.java#L3 maybe this would tell what is being done differently for this issue to be fixed? tbh im curious at this point

Xelbayria commented 1 year ago

is the issue resolved? if yes, then please close. otherwise, you can leave it open.

Shibva commented 1 year ago

I don't believe so; it seems to be working fine on fabric, but not on quilt for whatever reason

It's been a while since I've checked, since I moved off of quilt due to some issues that I've ran into. It's highly likely that the issue is still present

Xelbayria commented 1 year ago

alright. I supposed the issue is on the quilt since it should be compatible with Fabric mods.

Shibva commented 1 year ago

It's ironic; it should, but it's not really. I will try to see any quilt developers would know what's going on; they might have an idea what's causing this bug.

Thanks for your feedback