search

MehVahdJukaar / Supplementaries

Other
137 stars 96 forks source link

[Forge 1.19.2] Breaking textures when used with EMF and ETF #644

Open Aulberon opened 1 year ago

Aulberon commented 1 year ago

When using ETF/EMF to render custom entity models, if Supplementaries is present, the textures of the entity shift as seen in the image below.

Tried an instance with only the important mods(ETF, EMF, Moonlight and Supplementaries) but the problem persisted.

image

MehVahdJukaar commented 1 year ago

Just endermen?

MehVahdJukaar commented 1 year ago

I heard people using it with fresh animations for example with no issues

Aulberon commented 1 year ago

Yes, only the endermen seens to present this problem. I have tried with other mobs and all seens fine. I'm also using Fresh Animations and it works perfectly, the only problem seens to be the endermen having new textures. I'm using a modified version of the Enhanced Enderman resource pack, here is a copy if you need it. Enhanced+Endermans.zip

Aulberon commented 1 year ago

Here is a print of how it looks without supplementaries. image

MehVahdJukaar commented 1 year ago

weird im not even touching the enderman renderer nor model

MehVahdJukaar commented 1 year ago

also a texture change should always be compatible if it has the same dimensions and such

MehVahdJukaar commented 1 year ago

the only thing that must be is the enderman heads i have in the mods. I'm adding those using forge EntityRenderersEvent.CreateSkullModels event. I'm not familiar with the mod but could it be that said mods are ports of some fabric mod? if so I would assume that somebody didnt do their job properly as if this is the case they arent compatible with forge own api itself

MehVahdJukaar commented 1 year ago

tho tbh i doubt thats the case so idk

Xelbayria commented 11 months ago

is the issue resolved? if yes, then please close. I'm not sure if this is related to supplementaries

Barerock commented 2 months ago

Others in the Fresh Animations discord report the Enderman head specifically being broken by Supplementaries, and there are a few bug reports that note that Supplementaries sometimes affects the entire resource pack Fresh Animations, though I believe that to specifically be their order of files, not this mod's fault.

A common bug, which I have as well, is that Supplementaries will replace/mess up the rendering of the Enderman's head because of the way it's added into the mod, regardless of being enabled or not. In my case it appears as a regular Enderman with full animation support, but with no face and a hollow head. This is also the case for the Supplementaries Enderman Head item, which is what leads me to believe that its implementation specifically is what is causing this issue.

At least one member of that discord has tested Fresh Animations and Supplementaries isolated together, and found that it is indeed the two interacting poorly. So yes, it is related to Supplementaries.