MehVahdJukaar / Supplementaries

Other
125 stars 91 forks source link

[🐞]: Crash Upon Loading Map When Updating from 1.19.2 to 1.20.1 #921

Open Schoperation opened 5 months ago

Schoperation commented 5 months ago

Before Continuing:

Version

1.20.1-FORGE

Supplementaries Version

supplementaries-1.20-2.7.33

Moonlight Lib Version

moonlight-1.20-2.9.7

Issue Detail

Hello, my client crashes on a server (server itself still runs) whenever I load a chunk with an alleged broken map. Looking at the crash report, Supplementaries showed up a decent amount.

Removing the map solves the issue, and then happens again when I select it in my hotbar, or drop it on the ground. Removing Supplementaries solves the issue outright. Then when I look at it (re-rendering it), and add Supplementaries again, the issue is resolved.

I'm updating my pack from 1.19.2 to 1.20.1, so my guess is that there's some unsupported color on the map or something that just needs to be gracefully deleted upon updating.

FYI the linked crash report includes Quark, but I get the same issue without Quark enabled.

crash-2024-02-06_23.06.57-client.txt

MehVahdJukaar commented 5 months ago

do you have latest.log? crash is weirdly vague

MehVahdJukaar commented 5 months ago

I dont see any way how that method could ever fail unless some mod somehow passed some null invalid parameters and they propagated all the way down there

Schoperation commented 5 months ago

Sure thing; here's the debug as well.

latest.log debug.log

Keep in mind there's an unrelated issue with Lightman's Currency, so that's been spamming the logs