log flooded with sign texture errors

[Linguardium]

https://github.com/MehVahdJukaar/Supplementaries/blob/73fcd9508fb2f88aa0609bfe049e380fe5330f5f/common/src/main/java/net/mehvahdjukaar/supplementaries/dynamicpack/ClientDynamicResourcesGenerator.java#L236-L265

This should be an opt-in situation not a global situation. You are throwing errors for things that are not opting into your system and then logging those errors blaming other mods.

error snippet

[MehVahdJukaar]

It is opt in. You can disable enhanced hanging signs (and hence that stuff) via configs

[MehVahdJukaar]

Also that's not my system at all. That's vanilla system. If you add a wood type and it's texture isn't even in the vanilla maps then it's not done properly

[Linguardium]

• You then make an assumption about what exists based on the vanilla system, but you are the one generating invalid file paths and throwing errors, not vanilla, meaning its still your system having problems Sheets.getHangingSignMaterial(w.toVanilla()).texture())

• You can disable the system by changing a config value, which means by definition that as a user you have to opt out, not in. https://github.com/MehVahdJukaar/Supplementaries/blob/73fcd9508fb2f88aa0609bfe049e380fe5330f5f/common/src/main/java/net/mehvahdjukaar/supplementaries/configs/ClientConfigs.java#L403-L404

• You arent trying to get a texture from the vanilla renderer, you are generating it based on assumptions and then throwing errors for any mod that handles their own mod differently, telling the user that they can opt out of your system of vanilla sign modifications, which arent just for vanilla. As a mod developer making a sign mod without your mod in my environment at all, I would not be opting into anything.

your mods have errors being thrown for a global, user-opt-out system, based on assumptions you make about what might exist in the vanilla game without actually checking. you throw errors based on your unchecked assumptions mentioning a non-existent mod resource. Thats entirely a "your system" issue not a vanilla one

[MehVahdJukaar]

I'd that's what's failing then that's a bug. It's only supposed to log when those textures don't exist not when that returns null

[Linguardium]

Vanilla adds all wood types to the RenderLayer map, even if they arent used for hanging signs. the renderer would be using renderer.getTextureId which would handle the texture id for that renderer.

[MehVahdJukaar]

Alright so 2 things: I've tried so hard to import any of those mods (blockus, minecelss, ad astra and spectrum) but failed. They all have many dependencies which either are unliested like its the case for spectrum that has 3, one of them cant be even found on curseforge, or use other dependencies with JIJ which my architectury setup cant import. In the case of better archeology yungs api throws some error. In short I cannot import and test any of them.

Secondly i have checked the toVanilla call and that should just get the hanging sign block (which we know exist otherwise it wouldnt have appeared in that for loop to begin with, and then just call its own .type() method which returns the vanilla wood type so that should never be null

[Linguardium]

yes, importing is a no-go for many of them. ideally you should be applying only to vanilla and to mods that explicitly opt-in to your system.

without logging the actual error, its hard to say whats actually failing but i expect it either isn't finding a hanging sign for them (thus returning null) or you are trying to load the default texture id path instead of using the block's own renderer TextureId.

I would suggesting doing some checks at the head of the loop to verify the mod has both opted into your system and that the expected path exists. If either isn't true, dont process that wood type.

[MehVahdJukaar]

from what i can see (out of dev) all of those are failing because they are not adding stuff to the vanilla map. Now yes the rendererd returns that texture too and is arguably more accurate. I've just updated the code to fallback to that. Still one should still register stuff properly to the vanilla maps. That functon has a name and is not null by default so by contract it should not return null for any wood type. System hence remain opt out as if it would faul would necessairly mean that a mod isnt using the "vanilla system". Also what would be the need to register a custom tile renderer for hanging sign whent the vanilla one works the same?

Also noticed the code was missing a check for the existance of signs to behin with. Stil believe that to be a somehwat of error from mods that add wood but not hanging sign but that wast intented so that was resolved (gets rid of that one "alpha" wood type error)

[Linguardium]

if i recall correctly (also not in dev) BlockFamily doesnt list hanging signs, but does list signs. Vanilla is not consistent on what does and doesnt exist. Helper methods that generate a list of potential texture paths should not be expected to be a source of truth.

The vanilla renderer is fairly hardcoded. Sometimes its better to have your own custom renderer to be more flexible, hanging sign or not.

Not adding the hanging sign might just be an oversight from updating mods from old versions. if you see it, you may want to open issues on their trackers to let them know its missing,