MehVahdJukaar / Supplementaries

Other
125 stars 90 forks source link

[🐞]: `#minecraft:candles` block tag broken as of v2.8.0 #949

Closed unilock closed 4 months ago

unilock commented 4 months ago

Before Continuing:

Version

1.20.1-FORGE

Supplementaries Version

supplementaries-1.20-2.8.0

Moonlight Lib Version

moonlight-1.20-2.10.0-forge

Issue Detail

[Worker-Main-11/ERROR] [net.minecraft.tags.TagLoader/]: Couldn't load tag minecraft:candles as it is missing following references: 
    supplementaries:skull_candle (from supplementaries-1.20-2.8.0.jar)

I guess the skull_candle block was moved to Amendments, but its block tag entry was never removed from Supplementaries.

https://github.com/MehVahdJukaar/Supplementaries/blob/ca095f2a8776645c9f056d8eafbe06ddc8995cc7/common/src/main/resources/data/minecraft/tags/blocks/candles.json#L1-L6

MehVahdJukaar commented 4 months ago

fixed