search

MehVahdJukaar / Supplementaries

Other
137 stars 96 forks source link

Support Third-Party Items For Painting Tooltip #951

Closed ChloeDawn closed 7 months ago

ChloeDawn commented 7 months ago

Currently the feature for showing paintings on painting item tooltips is only applied to Items.PAINTING. If you instead checked instanceof HangingEntityItem and HangingEntityItem#type == EntityType.PAINTING it would allow the feature to work with mods such as Handcrafted - you can find their Fancy Painting implementation here. The caveat is that HangingEntityItem#type is private, so would need an Accessor mixin or equivalent.

MehVahdJukaar commented 7 months ago

holdup, are you sure they would have that type set to EntityType.PAINTING? wouldnt they have to useanother entity type?

MehVahdJukaar commented 7 months ago

well i see. added