MehVahdJukaar / WoodGood

Other
40 stars 24 forks source link

[🐞]: Hollow Stems Incorrectly Named Hollow Log #548

Closed Ghastly13 closed 2 days ago

Ghastly13 commented 4 days ago

Before Continuing:

Version

1.20.1

Loader

Forge

EveryCompat Version

2.6.65

Moonlight Lib Version

2.12.6

Issue with mods

The Aether: Redux 2.0.16c The Outer End 1.0.9 Endless Biomes 1.5.1 Regions Unexplored 0.5.5 Optional: Voidscape 1.5.389

Issue Detail

I noticed that when you fixed #545, that you also renamed the Hollow Logs to Hollow Stems. I have found every example of this issue in the set of mods that I use:

I also noticed that Voidscape adds a Thunder Stem that does not recieve a Hollow Stem variant, however I believe this is an issue with Voidscape as they also use an incorrect ID naming convention for the stripped stem block, thunder_stem_stripped as opposed to stripped_thunder_stem (which causes the stripped textures to not be detected).

OPTIONAL: Latest.log | Crash-report Attachment

No response

OPTIONAL: To Produce

No response

Xelbayria commented 4 days ago

I also noticed that Voidscape adds a Thunder Stem that does not recieve a Hollow Stem variant, however I believe this is an issue with Voidscape as they also use an incorrect ID naming convention for the stripped stem block, thunder_stem_stripped as opposed to stripped_thunder_stem (which causes the stripped textures to not be detected).

that's a great info, i can fix that.

and regarding the naming, it has to be a specific block from furniture mod which i can manually rename the title to "stem" from "log". I'll need to know which furniture mod. There is no way to fix that because Furniture Mod actually use the name like Quark's

hollow_\_log as the ID of the block. but the best way to fix it is just to change the title of the block which is seen as "Hollow \ Log".

Xelbayria commented 3 days ago

I need to know which furniture mod. the only 2 mods I know has the hollow_log are: Quark and The Twilight Forest

Ghastly13 commented 3 days ago

Sorry, I only tested Quark.

Xelbayria commented 3 days ago

Alright, i'll fix the naming. considered this fixed in next version: v2.6.66

Xelbayria commented 2 days ago

I cannot find Indigo Stem/Hollow Indigo Log, Outer End only have _azurestem

nvm. it turned out i have v1.0.8 for Outer End, had to update it to v1.0.9 (thought i had the latest one)

edit: again nvm. I'm sure that it doesn't have Indigo stem.