MehVahdJukaar / WoodGood

Other
51 stars 27 forks source link

[🐞]: No Woodworks chests generated for Quark wood types #549

Closed samuel-cote closed 3 months ago

samuel-cote commented 3 months ago

Before Continuing:

Version

1.20.1

Loader

Forge

EveryCompat Version

everycompat- 1.20-2.6.65

Moonlight Lib Version

moonlight- 1.20-2.12.6

Issue with mods

Issue Detail

Woodworks chests do not generate for wood types added by Quark. Trapped chests exist, but are unobtainable. This issue is confirmed with the listed mod versions, but has existed throughout multiple versions.

OPTIONAL: Latest.log | Crash-report Attachment

No response

OPTIONAL: To Produce

No response

Xelbayria commented 3 months ago

Oh, that's because Woodworks has no foreign woods added. Otherwise, if it do, chests would be generated with Quark and Woodworks. Quark has some woods added, IIRC.

Xelbayria commented 3 months ago

If there is more to this issue, i'll need more details.

samuel-cote commented 3 months ago

If there is more to this issue, i'll need more details.

The problem is that the Quark chests aren't present either. Adding Woodworks to a modpack with Quark and Every Compat prevents any standard chest made of Quark wood from being generated.

Xelbayria commented 3 months ago

gotcha

Xelbayria commented 3 months ago

interesting. this is an issue on Quark's side. I can confirm no recipes for chest & trapped_chest from Quark without EveryComp or Moonlight Lib I added a code for Woodworks' chest & _trappedchest to be skipped if Quark is installed.

let me know if that's a no problem or you would like to have woodworks chest & trapped_chest included, even with Quark installed

samuel-cote commented 3 months ago

As long as there's a functional chest for each wood type, which mod takes priority doesn't matter much to me!

Xelbayria commented 3 months ago

alright.

Xelbayria commented 3 months ago

Alright, I found the culprit. it's the config from Quark.

"Ignore Anti Overlap" = true under Building.variant_chests fixed the missing recipes for chest and _trappedchest. I think the issue is that Anti-Overlap is applied to Quark when Woodworks is installed. it's not perfect but there are other solutions to fix this such as using CraftTweaker or KubeJS.

chest & _trappedchest from Woodworks with Quark will be skipped. that's all.