MehVahdJukaar / WoodGood

Other
40 stars 24 forks source link

[🐞]: Missing textures for Macaw's hedge in [Let's Do] Meadow pine leaves. #550

Closed Robynstar closed 3 days ago

Robynstar commented 3 days ago

Before Continuing:

Version

1.20.1

Loader

Forge

EveryCompat Version

everycomp-1.20-2.6.65.jar

Moonlight Lib Version

moonlight-1.20-2.12.6-forge.jar

Issue with mods

Macaw's Fences and Walls - mcw-fences-1.1.2-mc1.20.1forge.jar [Let's Do] Meadow - letsdo-meadow-forge-1.3.17.jar

Issue Detail

When trying to render the Macaw's hedge in the Meadow pine leaves, we get the dreaded magenta and black squares: 2024-07-02_13 05 39 Confirmed with only the three mods in question.

The Macaw's hedge works just fine in other modded leaves (e.g. Apple/Grapevine from [Let's Do] Vinery), and other modded hedges (e.g. Quark, Mr Crayfish's Furniture Mod, Builders Crafts & Additions) work just fine in the pine leaves. Although interestingly it didn't even generate a Macaw's hedge in any of the Quark leaves (blossom/trumpet or ashen), nor a Mr Crayfish one, but did for Builders Crafts & Additions. And the Macaw's hedge generated for the Vinery Dark Cherry leaves is missing the cherries, despite them being present on the other three hedges.

OPTIONAL: Latest.log | Crash-report Attachment

No response

OPTIONAL: To Produce

No response

Robynstar commented 3 days ago

The failure to generate note at the end seems similar to #525, but I do not have any of the mods mentioned in the issue. I will investigate this further and put it in its own issue when/if I work out where the issue is coming from.

Xelbayria commented 3 days ago

Alright, I'll await for more info about #525. and the texture problem will be fixed.

Robynstar commented 3 days ago

Not sure it is actually that similar to #525, as most recipes are generated, and there are no error messages in the log. (only a few exceptions for 'vinery:blockstates/grapevine_leaves.json' which are always there) I have however found multiple instances of hedges missing/using incorrect textures. Do you want them all in one issue, or in separate issues? And if separate do you want them grouped by the texture source or the hedge source?

Xelbayria commented 3 days ago

Yes. Please create a separate issue with the texture source (that would be helpful) with hedge's ID from which wood mod

This issue is already closed blc it's focused on the Pine Leaves from Meadow. and is fixed. I'll await for your new issue.

EDIT:

you can use <type>_hedge - woodmod:block/<type>_leaves, i hope this is not too much of work.