MehVahdJukaar / WoodGood

Other
52 stars 28 forks source link

[🐞]: Latest Update Causes Crash on Server When Used with Variant Vanilla Blocks #578

Closed Helinos closed 1 month ago

Helinos commented 2 months ago

Before Continuing:

Version

1.20.1

Loader

Fabric

EveryCompat Version

everycomp-1.20-2.6.70

Moonlight Lib Version

moonlight-1.20-2.12.9-fabric

Issue with mods

Issue Detail

Crash when trying to start a server. This does not happen in single player.

OPTIONAL: Latest.log | Crash-report Attachment

latest.log Crash was not logged to the crash-report folder

OPTIONAL: To Produce

No response

Xelbayria commented 2 months ago

I'll check and this will be fixed in v2.6.71

ImBehinYa commented 1 month ago

can confrim same issue

Xelbayria commented 1 month ago

I can reproduce the issue on my side. idk why. I'm talking to MehVahdJukaar about this.

Xelbayria commented 1 month ago

good news: I found the cause of the problem (it's complicated) & bad news: it will take times to fix the problem.

mlus-asuka commented 1 month ago

Same issue.I guess you tried to use this method then failed register items Caused by: java.lang.ClassNotFoundException: net.minecraft.client.renderer.BlockEntityWithoutLevelRenderer at cpw.mods.cl.ModuleClassLoader.loadClass(ModuleClassLoader.java:141) ~[securejarhandler-2.1.10.jar:?] at java.lang.ClassLoader.loadClass(ClassLoader.java:525) ~[?:?] ... 59 more

Xelbayria commented 1 month ago

Same issue.I guess you tried to use this method then failed register items Caused by: java.lang.ClassNotFoundException: net.minecraft.client.renderer.BlockEntityWithoutLevelRenderer at cpw.mods.cl.ModuleClassLoader.loadClass(ModuleClassLoader.java:141) ~[securejarhandler-2.1.10.jar:?] at java.lang.ClassLoader.loadClass(ClassLoader.java:525) ~[?:?] ... 59 more

Thank you! You just helped me find one more class that I need to add the annotation. Annotation is to tell the SERVER to not use class (its' only used on CLIENT) so it can run properly.

however, the problem is the annotation is not being applied to BlockEntityRenderer, SERVER is still trying to find that class and leads to a crash

mlus-asuka commented 1 month ago

Same issue.I guess you tried to use this method then failed register items Caused by: java.lang.ClassNotFoundException: net.minecraft.client.renderer.BlockEntityWithoutLevelRenderer at cpw.mods.cl.ModuleClassLoader.loadClass(ModuleClassLoader.java:141) ~[securejarhandler-2.1.10.jar:?] at java.lang.ClassLoader.loadClass(ClassLoader.java:525) ~[?:?] ... 59 more

Thank you! You just helped me find one more class that I need to add the annotation. Annotation is to tell the SERVER to not use class (its' only used on CLIENT) so it can run properly.

however, the problem is the annotation is not being applied to BlockEntityRenderer, SERVER is still trying to find that class and leads to a crash

that's won't work if only use annotation. try run it in FMLClientStartUp event

Xelbayria commented 1 month ago

Fixed in v2.6.71

the problem is much more weirder than I thought.