MehVahdJukaar / WoodGood

Other
55 stars 30 forks source link

[🐞]: Reloading resource packs that modify every compat textures cause the mod to ungenerate its textures #651

Open thelegitdolt opened 3 hours ago

thelegitdolt commented 3 hours ago

Before Continuing:

Version

1.20.1

Loader

Forge

EveryCompat Version

everycomp-1.20-2.6.84H.jar

Moonlight Lib Version

moonlight-1.20-2.13.13-forge

Issue with mods

This appears to happen with every mod. I have installed Quark and Architect's Palette, and Autumnity.

Issue Detail

I have attempted to change some of every compat's assets with a texture pack

Screenshot 2024-10-23 at 10 09 58 PM

The above shows the image of all of the files that I changed.

When launching the game, everything is fine. However, if you reload the texture pack (F3 + T), the following happens:

Screenshot 2024-10-23 at 10 06 12 PM

OPTIONAL: Latest.log | Crash-report Attachment

https://gist.github.com/thelegitdolt/7e954f055e8a87c5c7f7755b0bf2df57 An excerpt. This shows all the models not being loaded yada yada.

OPTIONAL: To Produce

  1. Install this texture pack (unzip into texture pack folder) dolt_mod_resource.zip
  2. Launch the game with every compat installed as well as some mods that makes it generate some blocks I suppose
  3. Reload the texture ack
  4. Wow all the textures are gone
Xelbayria commented 2 hours ago

I need the latest.log to look at the errors. The gist.github you provide is only pointing at the missing the model for planks and other blocks from a few different mods

thelegitdolt commented 2 hours ago

i will give logs asap. I've also noticed that removing recipes + reloading will break the entire everycomp datapack

Xelbayria commented 2 hours ago

Ok i've tested your resource pack. I had no problem but what I did is unzipped the ZIP

dolt_mod_resource.zip > dolt_mod_resource > ...

I selected all of them and added to dolt_mod_resource.zip via context menu (7-zip > add to dolt_mod_resource.zip). The structure should look like this:

dolt_mod_resource.zip
    L> assets
    L> pack.mcmeta
    L> so on...

and use it as a resource pack. You need to change one thing in pack.mcmeta which is

TO

how do i know it's 15. take a look at pack_format

thelegitdolt commented 2 hours ago

I changed my pack resource to 15 and can still reproduce the issue. Did you reload the texture pack after you launched it

thelegitdolt commented 2 hours ago
Screenshot 2024-10-23 at 11 10 17 PM
Xelbayria commented 2 hours ago

Yes I also "reload the texture".

Some of blocks from Quark like hedges or fences, they don't need generated textures because they are using the vanilla textures from Minecraft. that applied to other wood mods (Biomes O' Plenty or Autumnity).

You only have these:

correct, if there are 1 or 2 more wood mods, i need to know which one.

thelegitdolt commented 2 hours ago

can you send the texture pack you used

thelegitdolt commented 2 hours ago

this is a copy of my everycomp config https://gist.github.com/thelegitdolt/60ea72fa572f138bf7894773bf5fb677 is there something here that owuld cuase any problems

thelegitdolt commented 2 hours ago

Some of blocks from Quark like hedges or fences, they don't need generated textures because they are using the vanilla textures from Minecraft. that applied to other wood mods (Biomes O' Plenty or Autumnity).

Yes, but they still require generated blockstates files and models, which is what is broken

Xelbayria commented 2 hours ago

github_issues_651

That's what it looks like. What i said in my post about the structure is very clear.

Yes, but they still require generated blockstates files and models, which is what is broken

They will get generated but something is preventing EveryCompat from finishing the job. It's the same recipes. you'll have to isolate all of mods down to one mod that is giving you the issue.

thelegitdolt commented 2 hours ago

i will do that