MehVahdJukaar / modelfix-multi

GNU General Public License v3.0
24 stars 8 forks source link

Crash with Cosmetica #11

Closed emoace closed 1 year ago

emoace commented 1 year ago

Hi I was making a pack and noticed that Cosmetica and this mod crash when trying to render the player, it seems. If I remove either one of them, then there are no crashes.

Here is the crash report:

crash-2023-01-03_01.21.11-client.txt

MehVahdJukaar commented 1 year ago

No idea. Maybe report to them too. Seems like calling this.atlas() throws an unconditional exception on their model when it shouldn't. I don't think there's much I can do besides add some direct compatibility workaround

emoace commented 1 year ago

I checked their github and it seems they are aware of this issue and have fixed it in dev, but they haven't released the fix yet: https://github.com/Cosmetica-cc/Cosmetica/issues/77

Julienraptor01 commented 1 year ago

They have released the fix and this issue could be closed

MehVahdJukaar commented 1 year ago

Nice