search

MehVahdJukaar / polytone

Other
31 stars 2 forks source link

Resource reload fails when biome effect modification is present #28

Closed miaumattimc closed 3 months ago

miaumattimc commented 3 months ago

Whenever I try to load my resource pack and it has biome effect modifiers in assets/minecraft/polytone/biome_effects, the resource loading screen appears twice, resulting in the message "Resource Reload failed". I have tried merging all files into one using the explicit targeting and also changing the pack namespace folder to a custom one, but nothing changed. The issue is clearly caused by the biome effects feature as a color.properties file worked just well (even though it didn't actually change the map colors, but for me this is not really important as I only tried to change biome music). I also created a new installation with just Fabric API and Polytone, but it didn't work either.

MehVahdJukaar commented 3 months ago

Latest.log will say exactly what is wrong and which part of the json you got wrong

miaumattimc commented 3 months ago

image found this in the log, apparently the custom sound event I created doesn't work, any idea how to resolve this?

MehVahdJukaar commented 3 months ago

biome special effect use same exact format as vanilla own stuff with same name. Refer to minecraft wiki for proper sintx or use misode generator website like wiki suggests

miaumattimc commented 3 months ago

I know, I've read the documentation entry. In fact, the wiki page features a different syntax than the vanilla gamefiles and the github generator (instead of {"music":{"sound":"[sound]"}}, it says {"music":{"sound":{"sound_id":"[sound]"}}}, but I used the format given by misode and the gamefiles. I'm adding two JSON files to this comment, one of them is for one particular biome and the other one uses specific targeting. snowy_biomes.json snowy_plains.json

MehVahdJukaar commented 3 months ago

so the ones you sent are NOT using the format you cited above. The second one is the correct one

MehVahdJukaar commented 3 months ago

wiki could be outdated but misode shouldnt be

miaumattimc commented 3 months ago

Thank you, using the second format indeed didn't make the game crash. Thank you for your support and sorry for creating this entry even though it wasn't a bug. Have a nice day!

MehVahdJukaar commented 3 months ago

no worries! If you make a pack remember to put add the polytone banner or mark is as a soft dep. Mod is still trying to become known

miaumattimc commented 3 months ago

Sure. I probably won't make it public but if I do I'll make sure to remember that!