search

MehVahdJukaar / polytone

Other
46 stars 5 forks source link

Can't change grass and foliage colors #46

Closed VindSole closed 6 months ago

VindSole commented 6 months ago

Seems like I can't change the above mentioned, neither can data driven colors like cherry grove's. Sky, fog, water and water fog do work.

MehVahdJukaar commented 6 months ago

Send your pack. Also be sure you aren't using sodium

VindSole commented 6 months ago

I’m using sodium, didn’t know there were conflicts with it.

MehVahdJukaar commented 6 months ago

Use embeddium

VindSole commented 6 months ago

Just tried again with embeddium and it still doesn't seem to work, here is the resource pack i'm testing this on, changed foliage and grass color on the cherry grove https://drive.google.com/file/d/1Ev6AglJDRAEt32MkEa4ezGpqpT3z_JnP/view?usp=sharing

MehVahdJukaar commented 6 months ago

that link you sent is private. Also are you sure about this? out of all colors that can be changed foliage and grass are the only 2 that dont need an extra mod for it as vanilla already has 2 textures for their colormaps

VindSole commented 6 months ago

Sorry, fixed link. With colormaps it's hard to know which pixel a given biome uses, cherry grove requires replacing the whole default .json file so yeah Imo it's handy to have these modifiable in polytone.

MehVahdJukaar commented 6 months ago

So ill test that. However if you want to have all those colors in a single file you could use a colormap with grid format instead, using a custom biome_id_mapper to assing each pixel a biome

MehVahdJukaar commented 6 months ago

Also i need to know which version you are using

MehVahdJukaar commented 6 months ago

Ok I can confirm this issue. I thought that embeddium was not affected by it but aparently it too doesnt look at those colors. I'll contact the author and see what can be done. This means that the colors wont work with embeddium or sodium but might with a future update of embeddium

MehVahdJukaar commented 6 months ago

Actually are you sure you tried with the very latest version of embeddium? this is supposed to not be an issue with that very version

VindSole commented 6 months ago

Tried the grid format with sodium, corrupts the entire game, will try with embeddium,

Using 1.20.6, embeddium 0.3.19, polytone 1.18.11, latest version of everything.

MehVahdJukaar commented 6 months ago

elaborate on buggy as hell. I worked today with 2 other people both using it with sodium. Also tested it myself today too with embeddium that time. Question above refers to the biome modifiers. Sodium completely ignores those vanilla objects. Embeddium 0.3.19 is supposed to work ok with them

VindSole commented 6 months ago

Blocks start rendering with random textures on sodium That's odd, tried a grid water colormap and it doesn't look correct on embeddium either.

VindSole commented 6 months ago

tried with a fresh instance with only embeddium and polytone.

MehVahdJukaar commented 6 months ago

send your pack so i can test

VindSole commented 6 months ago

Bedrock water colors V1.1.zip

MehVahdJukaar commented 6 months ago

that pack you send works fine for me. Other one tho had some issues and there was indeed a problem with embeddium compat. Quite a nightmare as forge+ embeddium + fabric all require very different aproaches so mine had to squeezebetween all of them. Anyways new version of the mod should work. Also has many new features

VindSole commented 6 months ago

Seems to work now on embeddium,