search

MehVahdJukaar / polytone

Other
31 stars 2 forks source link

[FABRIC] crash with sodium and indium #7

Closed glittermutt closed 5 months ago

glittermutt commented 5 months ago

:( crash report and log attached, i teleported to a stronghold and the game seemed to crash https://mclo.gs/hbCYPxM https://mclo.gs/ZrFvqpb

MehVahdJukaar commented 5 months ago

Oh noe

MehVahdJukaar commented 5 months ago

Omg why does sodium completely disregards vanilla biome colours providers. Seems like I have to add direct integration with it

glittermutt commented 5 months ago

noo i hope u can figure it out!!!

MehVahdJukaar commented 5 months ago

omg and they made it an enum with no regard whatsoever to mods that miding add some of those and no way to extend it other than going nuclear with a super complicaated core mod i dont even know how to do

MehVahdJukaar commented 5 months ago

oh would you look at that theres a PR on sodium exactly for this. too bad its still not being merged for 3 weeks https://github.com/CaffeineMC/sodium-fabric/pull/2222

MehVahdJukaar commented 5 months ago

I'll disable colormaps for now. polytone has no way of getting them to work without this. This is completely their issue for not only replacing vanilla system without inheriting from it as it should but also keeping it extremely locked up and non expandable with that enum. My hands are tied until that PR is merged

glittermutt commented 5 months ago

i hope it gets merged 😭

glittermutt commented 5 months ago

i updated polytone to the latest version, but it still crashed ^^; crash report and log attached https://mclo.gs/jC3vVYT https://mclo.gs/FSrd1on

jellysquid3 commented 5 months ago

... Omg why does sodium completely disregards vanilla biome colours providers... ... This is completely their issue for not only replacing vanilla system without inheriting from it as it should...

Yes, Sodium prohibits the use of custom color resolvers, just like Minecraft does. We talked with a maintainer of Fabric API to consider adding an interface for mods to register custom color providers (which resulted in this pull request) and my hope is that it can be accepted soon, so that mods don't need to mixin into Minecraft to use custom color resolvers.

But to be clear, it's not really reasonable to expect that Sodium should anticipate (and support) every possible way that mods can mixin to vanilla code. It's even less reasonable to expect that we should then design all of our code to be easily hacked by other mods. This is what leads to a fragile and unmaintainable ecosystem. Modders should instead work with each other, and the platform maintainers, to create stable interfaces (like the linked pull request tries to solve.)

Anyways. Sorry your mod is broken with Sodium. We'll be publishing Sodium 0.5.6 some time within the next few days with a fix for the problem.

Uranite commented 5 months ago

Sodium 0.5.6 is out! 🎉

glittermutt commented 5 months ago

hey, is sodium 0.5.6 going to be only for 1.20.3+ only?

glittermutt commented 5 months ago

NEVERMIND IM A CRETIN