MehVahdJukaar / sleep_tight

Other
2 stars 9 forks source link

Config Common File Resetting #51

Closed AetheriMC closed 11 months ago

AetheriMC commented 11 months ago

Minecraft v1.20.1 Forge v47.2.4 Sleep Tight v1.20-1.1.9

When modifying the configs, whether through the config files directly or through the Forge Config Screens mod UI, upon loading the game the configs reset and all changes are deprecated to a backup file.

If possible, moving these configs to server-side would be beneficial as well.

MehVahdJukaar commented 11 months ago

I need latest.log of a game that boots after those have been changed, should say what's wrong and why they are getting reset. Also why server confugs? I went through extra steps to have those common confugs like that as they are much more user friendly rather than the ones in a per world folder

AetheriMC commented 11 months ago

Here you are: 2023-11-29-4.log

While I verified that this log contains Sleep Tight, if you don't see what you're after let me know and I'll dig through for a different log. I had reset the server a few times attempting to identify what was happening.

My thought was to have the configs be server side so that they couldn't be changed by non-admin players. That being said, if you tell me that having server-side configs is not necessary to achieve that, then I'll be happy either way. :)

MehVahdJukaar commented 11 months ago

if a server has a config file a player can change their local common just fine but its not like the server asks the client what their common cofnigs are and overrides its own with them

MehVahdJukaar commented 11 months ago

it just uses its own

MehVahdJukaar commented 11 months ago

as for the configs resettings i just tried on a new fabric 1.20 instance and they didnt get reset adter i changed some random values

AetheriMC commented 11 months ago

This is happening in the forge version.

What I did just now is reinstall the mod with the configs modified on the server. I then started the server and checked the config folder and now I have 2 config files for ST. One is a "fresh" config that comes with the mod, the other is a backup of the config containing the numbers I modified. If I look at the configs in game, the default configs are in place.

image

image

The fresh config - https://pastebin.com/ccx1wsdb The backup with modified values -https://pastebin.com/RHRsSfXX

Edit Adding for clarity, I let the game generate the configs, then closed the server, edited the configs, and then started the server back up to produce the double configs above.

MehVahdJukaar commented 11 months ago

what is this image

MehVahdJukaar commented 11 months ago

thats incorrect it will make the config reset

MehVahdJukaar commented 11 months ago

firstof all its an integer, supports no decimals. secondly even if it did it would use . not comma

AetheriMC commented 11 months ago

Ha! Removing the comma fixed the config reset. Thank you for the assistance.