MehVahdJukaar / sleep_tight

Other
1 stars 9 forks source link

Compatibility issue immersive portals, unbreakable blocks #52

Open AntonyCilleros opened 8 months ago

AntonyCilleros commented 8 months ago

When using with immersive portals, the other dimensions are bugged. 1.20.1

I didn't do further test but I tried Sleep Tight (forge) with Immersive Portals (Fabric) by setting the nether bellow the Overworld and every block in the nether become unbreakable. I also can't change my gamemode, with an error appearing in the chat. Tested on multiple new worlds. When removing either immersive portals or sleep tight, the issue is fixed.

of course I used Sinytra Connector for immersive portals but the error is maybe also here without it. but since immersive portals is not ported on forge for 1.20.1, I am forced to use Sinytra

MehVahdJukaar commented 8 months ago

Are you sure this is related to sleep tight? Seems awfully specific to be related to it

AntonyCilleros commented 8 months ago

As I said, when I remove either Immersive Portals or Sleep Tight, the problem disappears so yes it is somehow related to sleep tight. I must admit that I have some other mods though so maybe the bug comes from Immersive Portals, Sleep Tight and another mod combined but I don't think so.

MehVahdJukaar commented 8 months ago

i didnt even manage to boot with connector. Its likely a connecotr issue. no idea why sleep tight would have anything to do here as it doesnt touch any of that stuff in the slightest

AntonyCilleros commented 8 months ago

It works fine for me with connector but only by using the forge version

MehVahdJukaar commented 8 months ago

Forge version of what?

AntonyCilleros commented 8 months ago

Sleep tight

MehVahdJukaar commented 8 months ago

I'm confused then. If it works what's the issue?

AntonyCilleros commented 8 months ago

Sorry it's maybe because I am not fluent in english. Sleep Tight (forge) and Sinytra works fine together but when I add Immersive portals (fabric) the issue described above appears. And the issue remains until I remove either Sleep Tight or Immersive Portals.

AntonyCilleros commented 7 months ago

I am here to bring proof I am on 1.20.1. I only have sinytra connector, forgified fabric api, sleep tight, moonlight lib and immersive portals (the only fabric mod here). and whenever I go to the nether, problems come. I can't die, sometimes I can't destroy blocks and the error I get constantly is that I can't change my gamemode and when I try I have this error and it only happens in the nether : image

here is a screen of my mods folder of my fresh install of minecraft 1.20.1 image

So there is a compatibility issue between Immersive portals (fabric) and Sleep Tight (forge) on 1.20.1. If I remove either Immersive Portals or Sleep Tight, everything works fine. I know this two mods are really unlikely to mess with each other but for some reasons it does. I know it may be a sinytra related issue so I should maybe open an issue on the sinytra's repo instead of here but idk

MehVahdJukaar commented 7 months ago

I'm not sure but must be due to something with connector. Does it work after relogging? what about if you are in survival? send laetst.log

AntonyCilleros commented 7 months ago

here are my logs https://paste.atlauncher.com/view/15ccc727-3bf2-43a5-99b1-71f7fd0ad459 after trying to execute /gamemode creative and /gamemode survival in the nether.

If I logout and reload the world then I am in the gamemode that I chose previously with the /gamemode command, even it had printed me an error. If I login in the nether I can change my gamemode as I want but when I go back in the overworld, I can't change my gamemode anymore and I have the error message. So I need to relog again.

I tested running your mod and immersive portals on fabric so without sinytra and there is no issue.

additionally, I encountered another bug in the nether with Immersive portals using sinytra connector and either Hardcore Revival or PlayerRevive. if I go to the nether with these mods, I can't die (even if I go back to the overworld). And if I run these mods on fabric without sinytra, everything is fine.

conclusion, something is off with sinytra and immersive portals in the nether (and maybe even other dimensions) So I don't think you can really do something, I will open an issue on sinytra. Sorry to have bothered you for nothing. You can close this issue if you want

MehVahdJukaar commented 7 months ago

i see my mod method being called my iw portal stuff. however log isnt very descriptive and doesnt say the last cause of the error. by checking my code that method is just 2 lines and i see no way that could fail. Idk why that log looks like that tho. are you sure you are sending me the right file? it doesnt have the usual info latest.log has like mod list and such.

mixin method in question is this

image I see no way how could that ever fail, even if a null was passed around it would call one of those methods in there and then crash there which isnt the case. and that decrement can never fail. decrementing an integer can never fail under any circumstances so i have no clue

AntonyCilleros commented 7 months ago

I opened an issue on sinytra's repo : https://github.com/Sinytra/Connector/issues/694

Sorry I just copied the console of atlauncher thinking it would be the same as latest.log. latest.log https://pastebin.com/jxxVUssn

MehVahdJukaar commented 7 months ago

that latest.log says where issue is as it shows way more lines on stack trace. Its connector somehow nuking my sleep capability. that too should be impossible as its assigned immediately using attach caps event