search

Mehdi-Rh / Fish-dishes-Capstone

This is a web application that displays only fish dishes available on the “themealdb” API and displays them into cards with the option of commenting on it.
8 stars 0 forks source link

Kanban board project #21

Open Mehdi-Rh opened 2 years ago

Mehdi-Rh commented 2 years ago

Kanban board project link: https://github.com/Mehdi-Rh/Javascript-Capstone/projects/2 Number of collaborators: 3

Student A: Mehdi Rahal Student B: Moise Mulungu Student C: Stanley Simeon

TedLivist commented 2 years ago

STATUS: CHANGES REQUIRED ♻️ ♻️

Hi @Mehdi-Rh, @moise-mulungu and @stanleySimeon,

Good job so far! ✔️ Kanban board columns are correctly set up ✔️ Tasks are complete However, there are some issues that you still need to work on to go to the next project but you are almost there!

Required Changes ♻️

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the Issue thread if something is not 100% clear. And please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Issue for re-reviews. You should use the same Issue submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Mehdi-Rh commented 2 years ago

Hello @TedLivist, can you check please the issue description to confirm the correctness of the changes?

TedLivist commented 2 years ago

@Mehdi-Rh, I can't seem to understand what you meant by description. Your issues have descriptions but aren't assigned to anyone yet. See example below

mehdi-assign

Mehdi-Rh commented 2 years ago

Ahh now I understand, thanx @TedLivist

Mihndim2020 commented 2 years ago

STATUS: APPROVED!!! 🎉 🎉 🎉 :champagne: :champagne: :champagne:

Hi Team,

Your project is complete! Great work on making the changes requested by the previous reviewer. There is nothing else to say other than... it's time to merge it :shipit: Congratulations! 🎉 🎉 🎉 :champagne: :champagne: :champagne:

Congratulations-Memes-FEATURED

Optional suggestions

Check the comments under the review.

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.