medaminedev66
commented
2 years ago Hi @Mehdi-Rh and @saied2035, :wave:
Good job so far! There are some issues that you still need to work on to go to the next project but you are almost there!
To Highlight
1. You really did well with your commit message, bravo, keep that up. .2 Good job using flex and grid to layout your application, well done.
Required Changes ♻️
- [ ] Good job so far but your mobile design still needs some work to be done there. I examined your app using the browser dev tools and the layout was overlapping each other, please put in mind all various device-width breakpoints such as 400px, 760px, etc.
- I would recommend using a mobile-first design approach, which means you should build your portfolio for the mobile version first, then try to use media queries for the Desktop breakpoint in the CSS file. (the value for
min-widthproperty should be in range of992px-1100px). - Your mobile version looks like this:
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Mehdi-Rh
t
In this PR, I have made the desktop version of the portfolio using the media query.