search

MehmedGIT / OtoN_Converter

Converter from basic OCRD process workflow to Nextflow workflow script
Apache License 2.0
4 stars 1 forks source link

Add docker parameters for models #7

Closed mweidling closed 1 year ago

mweidling commented 1 year ago

This PR introduces parameters for the location of OCR models to the config.toml in case a Dockerized workflow is created. These are used to mount a volume for the models to a container as described in https://ocr-d.de/en/models#models-and-docker.

Furthermore it fixes to minor issues:

  1. Some variable names haven't been changed according to the recent refactoring. These overlooked cases have been corrected.
  2. Installing oton in a venv causes errors since the requirements.txt lacked an entry for nextflow. This has been inserted.
MehmedGIT commented 1 year ago

Regarding 2.

It is worth mentioning that adding nextflow to the requirements does not install Nextflow, but just a Python wrapper around Nextflow [1]. The converter, however, does not use that wrapper.

I have just tested with a fresh Python3.8 venv and seems we must add wheel to the requirements as well. However, no complaints about missing nextflow inside the requirements.txt. What kind of error do you get?