search

MehmetAzizYirik / MAYGEN

MAYGEN is an open source chemical structure generator based on the orderly graph generation method.
MIT License
47 stars 16 forks source link

Fixed sonar warnings. #113

Closed javadev closed 2 years ago

codecov-commenter commented 2 years ago

Codecov Report

Merging #113 (7e39b74) into main (0554cc1) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #113   +/-   ##
=========================================
  Coverage     77.55%   77.55%           
  Complexity      587      587           
=========================================
  Files             5        5           
  Lines          2134     2134           
  Branches        465      465           
=========================================
  Hits           1655     1655           
  Misses          374      374           
  Partials        105      105
Impacted Files Coverage Δ
src/main/java/maygen/Maygen.java 81.18% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0554cc1...7e39b74. Read the comment docs.

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

javadev commented 2 years ago

@MehmetAzizYirik this pull request will fix all sonar warnings.

javadev commented 2 years ago

It will fix these sonar warnings

image

MehmetAzizYirik commented 2 years ago

It will fix these sonar warnings

image

@javadev did you fix the issues ? should I merge them or wait ?

javadev commented 2 years ago

@MehmetAzizYirik this pull request will fix issues.